Bug 33699 - webkit-patch upload should assign the bug to you
Summary: webkit-patch upload should assign the bug to you
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 59061
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-14 16:59 PST by Eric Seidel (no email)
Modified: 2011-04-21 17:34 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.73 KB, patch)
2011-04-20 14:23 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (5.85 KB, patch)
2011-04-20 14:27 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2011-04-21 14:27 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (6.66 KB, patch)
2011-04-21 14:31 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (6.83 KB, patch)
2011-04-21 14:45 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (6.89 KB, patch)
2011-04-21 14:46 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-14 16:59:58 PST
webkit-patch upload should assign the bug to you
Comment 1 Eric Seidel (no email) 2011-04-06 16:24:58 PDT
This already works during bug creation, but not when uploading new patches.
Comment 2 Adam Barth 2011-04-20 14:23:01 PDT
Created attachment 90413 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-04-20 14:24:30 PDT
Comment on attachment 90413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90413&action=review

> Tools/Scripts/webkitpy/tool/steps/postdiff.py:50
> +        if self._tool.bugs.fetch_bug(bug_id).is_unassigned():

You should put a FIXME here that we should cache the Bug object.
Comment 4 Adam Barth 2011-04-20 14:27:09 PDT
Created attachment 90414 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-04-20 16:08:53 PDT
Comment on attachment 90414 [details]
Patch for landing

Clearing flags on attachment: 90414

Committed r84431: <http://trac.webkit.org/changeset/84431>
Comment 6 WebKit Commit Bot 2011-04-20 16:08:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Adam Barth 2011-04-20 19:26:30 PDT
We need to check whether the assigned_to field exists in the form.
Comment 8 Adam Barth 2011-04-21 14:27:52 PDT
Created attachment 90602 [details]
Patch
Comment 9 Adam Barth 2011-04-21 14:31:08 PDT
Created attachment 90604 [details]
Patch for landing
Comment 10 Eric Seidel (no email) 2011-04-21 14:41:01 PDT
Comment on attachment 90604 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=90604&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:757
> +            log("Cannot find assigned_to control.  Do you have the EditBugs privilege?")

I would explain to the user what this means, give them action they can take.  Something like:

Failed to assign bug to you (can't find assigned_to) control.  Do you have EditBugs privilages at bugs.webkit.org?

You should email webkit-committers@webkit.org or ask in #webkit for someone to add EditBugs to your account to make patch contribution easier, etc.
Comment 11 Adam Barth 2011-04-21 14:45:43 PDT
Created attachment 90606 [details]
Patch for landing
Comment 12 Adam Barth 2011-04-21 14:46:23 PDT
Created attachment 90607 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2011-04-21 17:25:38 PDT
The commit-queue encountered the following flaky tests while processing attachment 90607 [details]:

http/tests/xmlhttprequest/access-control-preflight-credential-sync.html bug 59160 (author: jchaffraix@webkit.org)
The commit-queue is continuing to process your patch.
Comment 14 WebKit Commit Bot 2011-04-21 17:34:39 PDT
Comment on attachment 90607 [details]
Patch for landing

Clearing flags on attachment: 90607

Committed r84575: <http://trac.webkit.org/changeset/84575>
Comment 15 WebKit Commit Bot 2011-04-21 17:34:45 PDT
All reviewed patches have been landed.  Closing bug.