Bug 33679 - [Android] Android requires Geolocation::suspend/resume to be public
: [Android] Android requires Geolocation::suspend/resume to be public
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: Android Android
: P2 Normal
Assigned To: Steve Block
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-14 09:52 PST by Steve Block
Modified: 2010-01-15 12:53 PST (History)
5 users (show)

See Also:


Attachments
Patch 1 for Bug 33679 (1.58 KB, patch)
2010-01-14 10:04 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch 2 for Bug 33679 (2.29 KB, patch)
2010-01-14 10:25 PST, Steve Block
no flags Details | Formatted Diff | Diff
Patch 3 for Bug 33679 (2.38 KB, patch)
2010-01-14 10:29 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-14 09:52:51 PST
Android requires Geolocation::suspend/resume to be public. These were made private in https://bugs.webkit.org/show_bug.cgi?id=32499
Comment 1 Steve Block 2010-01-14 10:04:49 PST
Created attachment 46582 [details]
Patch 1 for Bug 33679
Comment 2 Steve Block 2010-01-14 10:25:08 PST
Created attachment 46584 [details]
Patch 2 for Bug 33679
Comment 3 Steve Block 2010-01-14 10:29:51 PST
Created attachment 46585 [details]
Patch 3 for Bug 33679
Comment 4 Eric Seidel 2010-01-14 17:19:17 PST
Comment on attachment 46585 [details]
Patch 3 for Bug 33679

Why don't the other ports need these public?
Comment 5 Eric Seidel 2010-01-14 17:19:44 PST
Who else works on Geolocation (outside of Android) who should be CC'd on geolocation bugs?
Comment 6 Steve Block 2010-01-15 02:19:05 PST
(In reply to comment #4)
> (From update of attachment 46585 [details])
> Why don't the other ports need these public?
I'm not sure, but I don't think that any other ports have complete Geolocation implementations fully upstreamed to WebKit. Android uses these methods to disable the GPS when a page using Geolocation is not in the foreground, to save battery.

> Who else works on Geolocation (outside of Android) who should be CC'd on
> geolocation bugs?
Nobody. Sam (already cc'ed) wrote the change in Bug 32499 which introduced this breakage, and said he'd put back the suspend/resume methods.
Comment 7 Eric Seidel 2010-01-15 10:07:41 PST
Comment on attachment 46585 [details]
Patch 3 for Bug 33679

OK.
Comment 8 WebKit Commit Bot 2010-01-15 12:53:21 PST
Comment on attachment 46585 [details]
Patch 3 for Bug 33679

Clearing flags on attachment: 46585

Committed r53342: <http://trac.webkit.org/changeset/53342>
Comment 9 WebKit Commit Bot 2010-01-15 12:53:28 PST
All reviewed patches have been landed.  Closing bug.