Bug 33677 - [V8] Standardize V8 generated and custom bindings on a single toNative() conversion method
Summary: [V8] Standardize V8 generated and custom bindings on a single toNative() conv...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks: 32563
  Show dependency treegraph
 
Reported: 2010-01-14 09:38 PST by Nate Chapin
Modified: 2010-01-14 14:09 PST (History)
2 users (show)

See Also:


Attachments
patch (140.16 KB, patch)
2010-01-14 10:16 PST, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff
the rest (21.68 KB, patch)
2010-01-14 12:11 PST, Nate Chapin
japhet: commit-queue-
Details | Formatted Diff | Diff
the rest - compile fixed (23.18 KB, patch)
2010-01-14 12:24 PST, Nate Chapin
dglazkov: review+
japhet: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-01-14 09:38:38 PST
Currently, we've got multiple functions doing essentially the same work.  Make it stop.
Comment 1 Nate Chapin 2010-01-14 10:16:58 PST
Created attachment 46583 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-01-14 10:25:17 PST
Comment on attachment 46583 [details]
patch

This is freaky-good. Nate++.
Comment 3 Nate Chapin 2010-01-14 12:10:38 PST
Comment on attachment 46583 [details]
patch

http://trac.webkit.org/changeset/53271
Comment 4 Nate Chapin 2010-01-14 12:11:10 PST
Created attachment 46593 [details]
the rest

This will break the chromium canaries.
Comment 5 WebKit Review Bot 2010-01-14 12:15:57 PST
Attachment 46593 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/187587
Comment 6 Nate Chapin 2010-01-14 12:24:08 PST
Created attachment 46595 [details]
the rest - compile fixed

Removing a function that I forgot to update because it isn't called anywhere.
Comment 7 Dimitri Glazkov (Google) 2010-01-14 13:48:09 PST
Comment on attachment 46595 [details]
the rest - compile fixed

Even betterrer.
Comment 8 Nate Chapin 2010-01-14 14:09:36 PST
http://trac.webkit.org/changeset/53290