Bug 33670 - Allow custom memory allocation control for Peer class
Summary: Allow custom memory allocation control for Peer class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-14 05:16 PST by Zoltan Horvath
Modified: 2010-01-15 00:32 PST (History)
1 user (show)

See Also:

Attachments
proposed patch (1.56 KB, patch)
2010-01-14 05:18 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2010-01-14 05:16:50 PST 
Inherits the following class from Noncopyable because it is instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
class Peer - websockets/WebSocketChannelClient.h:38
Comment 1 Zoltan Horvath 2010-01-14 05:18:17 PST 
Created attachment 46557 [details]
proposed patch
Comment 2 Oliver Hunt 2010-01-14 09:55:22 PST 
Comment on attachment 46557 [details]
proposed patch

why isn't WebSocketChannelClient just made noncopyable?
Comment 3 Eric Seidel (no email) 2010-01-14 12:54:52 PST 
Attachment 46557 [details] was posted by a committer and has review+, assigning to Zoltan Horvath for commit.
Comment 4 Zoltan Horvath 2010-01-15 00:28:49 PST 
(In reply to comment #2)
> why isn't WebSocketChannelClient just made noncopyable?

WebSocketChannelClient is an abstract base class, we don't want to modify it.
Comment 5 Zoltan Horvath 2010-01-15 00:31:57 PST 
Comment on attachment 46557 [details]
proposed patch

Clearing flags on attachment: 46557

Committed r53326: <http://trac.webkit.org/changeset/53326>
Comment 6 Zoltan Horvath 2010-01-15 00:32:06 PST 
All reviewed patches have been landed.  Closing bug.