RESOLVED FIXED 33670
Allow custom memory allocation control for Peer class 
https://bugs.webkit.org/show_bug.cgi?id=33670
Summary Allow custom memory allocation control for Peer class
Zoltan Horvath
Reported 2010-01-14 05:16:50 PST
Inherits the following class from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class Peer - websockets/WebSocketChannelClient.h:38
Attachments
proposed patch (1.56 KB, patch)
2010-01-14 05:18 PST, Zoltan Horvath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2010-01-14 05:18:17 PST
Created attachment 46557 [details] proposed patch
Oliver Hunt
Comment 2 2010-01-14 09:55:22 PST
Comment on attachment 46557 [details] proposed patch why isn't WebSocketChannelClient just made noncopyable?
Eric Seidel (no email)
Comment 3 2010-01-14 12:54:52 PST
Attachment 46557 [details] was posted by a committer and has review+, assigning to Zoltan Horvath for commit.
Zoltan Horvath
Comment 4 2010-01-15 00:28:49 PST
(In reply to comment #2) > why isn't WebSocketChannelClient just made noncopyable? WebSocketChannelClient is an abstract base class, we don't want to modify it.
Zoltan Horvath
Comment 5 2010-01-15 00:31:57 PST
Comment on attachment 46557 [details] proposed patch Clearing flags on attachment: 46557 Committed r53326: <http://trac.webkit.org/changeset/53326>
Zoltan Horvath
Comment 6 2010-01-15 00:32:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.