Bug 33663 - check-webkit-style underscore check should be disabled for Qt methods starting with qt_
: check-webkit-style underscore check should be disabled for Qt methods startin...
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: PC All
: P3 Normal
Assigned To:
:
: Qt
:
:
  Show dependency treegraph
 
Reported: 2010-01-14 02:57 PST by
Modified: 2010-01-17 18:06 PST (History)


Attachments
Patch (2.43 KB, patch)
2010-01-17 15:46 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-01-14 02:57:39 PST
check-webkit-style underscore check should be disabled for Qt methods starting with qt_, as Qt uses that for private API, such as for the DRT only.
------- Comment #1 From 2010-01-14 03:09:06 PST -------
We could even restrict this allowance to the qt directory, although allowing qt_ anywhere is really not a problem either.
------- Comment #2 From 2010-01-14 03:32:08 PST -------
I would still like the underscore check so make sure that the patches we receive do not use names like _privateMessage() etc.
------- Comment #3 From 2010-01-17 15:46:45 PST -------
Created an attachment (id=46763) [details]
Patch
------- Comment #4 From 2010-01-17 16:06:41 PST -------
*** Bug 33116 has been marked as a duplicate of this bug. ***
------- Comment #5 From 2010-01-17 17:35:09 PST -------
(From update of attachment 46763 [details])
Thanks for fixing this issue!
------- Comment #6 From 2010-01-17 18:06:16 PST -------
(From update of attachment 46763 [details])
Clearing flags on attachment: 46763

Committed r53381: <http://trac.webkit.org/changeset/53381>
------- Comment #7 From 2010-01-17 18:06:25 PST -------
All reviewed patches have been landed.  Closing bug.