RESOLVED FIXED Bug 33663
check-webkit-style underscore check should be disabled for Qt methods starting with qt_ 
https://bugs.webkit.org/show_bug.cgi?id=33663
Summary check-webkit-style underscore check should be disabled for Qt methods startin...
Kenneth Rohde Christiansen
Reported 2010-01-14 02:57:39 PST
check-webkit-style underscore check should be disabled for Qt methods starting with qt_, as Qt uses that for private API, such as for the DRT only.
Attachments
Patch (2.43 KB, patch)
2010-01-17 15:46 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-01-14 03:09:06 PST
We could even restrict this allowance to the qt directory, although allowing qt_ anywhere is really not a problem either.
Kenneth Rohde Christiansen
Comment 2 2010-01-14 03:32:08 PST
I would still like the underscore check so make sure that the patches we receive do not use names like _privateMessage() etc.
Adam Barth
Comment 3 2010-01-17 15:46:45 PST
Created attachment 46763 [details] Patch
Adam Barth
Comment 4 2010-01-17 16:06:41 PST
*** Bug 33116 has been marked as a duplicate of this bug. ***
Shinichiro Hamaji
Comment 5 2010-01-17 17:35:09 PST
Comment on attachment 46763 [details] Patch Thanks for fixing this issue!
WebKit Commit Bot
Comment 6 2010-01-17 18:06:16 PST
Comment on attachment 46763 [details] Patch Clearing flags on attachment: 46763 Committed r53381: <http://trac.webkit.org/changeset/53381>
WebKit Commit Bot
Comment 7 2010-01-17 18:06:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.