Bug 33660 - [Chromium] Fix a bug that a selected word is not recognized as a spell-check source.
Summary: [Chromium] Fix a bug that a selected word is not recognized as a spell-check ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-14 01:50 PST by Kent Tamura
Modified: 2010-01-31 17:45 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2010-01-14 01:52 PST, Kent Tamura
jorlow: review+
jorlow: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-01-14 01:50:58 PST
[Chromium] Fix a bug that a selected word is not recognized as a spell-check source.
Comment 1 Kent Tamura 2010-01-14 01:52:57 PST
Created attachment 46549 [details]
Patch
Comment 2 Kent Tamura 2010-01-14 02:37:34 PST
The current implementation of isASingleWord() means:
   "true if the text has no characters."
Comment 3 Eric Seidel (no email) 2010-01-14 17:22:26 PST
You should CC people who you think could best review this.  I'm not familiar with this code.
Comment 4 Kent Tamura 2010-01-14 18:33:43 PST
isASingleWord() implementation was changed during upstreaming WebKit API.
The last revision in Chromium repository seems to have a correct implementation.

http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813
Comment 5 Kent Tamura 2010-01-14 21:41:57 PST
(In reply to comment #4)
> isASingleWord() implementation was changed during upstreaming WebKit API.
> The last revision in Chromium repository seems to have a correct
> implementation.
> 
> http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813

Correction: It was changed by Chromium r29814, http://src.chromium.org/viewvc/chrome?view=rev&revision=29814, Moving it from webkit/glue/ to webkit/api/src.
Comment 6 Jeremy Orlow 2010-01-31 00:05:39 PST
Comment on attachment 46549 [details]
Patch

I don't know this code super well, but assuming this is just up-streaming a downstream fix (that was presumably reviewed): r=me
Comment 7 Kent Tamura 2010-01-31 17:45:51 PST
Landed as r54119 <http://trac.webkit.org/changeset/54119>