Bug 33656 - webkit.org/pending-review should route to a better list
Summary: webkit.org/pending-review should route to a better list
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-14 00:20 PST by Eric Seidel (no email)
Modified: 2015-12-07 10:08 PST (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-14 00:20:47 PST
webkit.org/pending-review should route to a better list

Since pending-review was created, Maciej has come up with several better (in my mind) queries for viewing the list of patches to review.  We should consider updating pending-review to reflect one of those fancier queries. :)

patches needing generic review:

patches needing specialized review (mostly [Gtk] or [Qt]):

all patches needing review:

I vote that we use #3 for /pending-review.

The current /pending-review points to:

which Oliver Hunt mentioned tonight is confusing because it lists both commit-queue? patches and review? patches.
Comment 1 Eric Seidel (no email) 2010-01-14 00:22:00 PST
/pending-review does not seem to be kept in WebKitSite, so it might be an apache-side config setting.  If so I'm not sure who we'd contact to get it changed.  I'll email webkit-dev.
Comment 2 Chris Jerdonek 2010-01-14 00:42:11 PST
I think these URLs should also have an appropriate sort order built into them -- perhaps by the amount of time they've been waiting for review if possible, or something similar that's age-related.

Alternatively, it can be sorted by "importance" and secondarily age, if the measure of importance can be relied upon.

If I recall, the first 2 URLs in comment 0 (in addition to the third) use order=Reuse+same+sort+as+last+time, which might not be the best choice.
Comment 3 William Siegrist 2010-01-14 06:43:15 PST
The redirects are indeed server side and in an internal repository. Email me or assign this bug to me when you want it changed.