[Chromium] Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.

[Marcus Bulach]

Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.

[Marcus Bulach]

Created attachment 46536 [details]
Patch

[Jeremy Orlow]

> Index: WebKit/chromium/ChangeLog
> ===================================================================
> --- WebKit/chromium/ChangeLog	(revision 53232)
> +++ WebKit/chromium/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> [phone]  Marcus Bulach  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.

Need to add the bug number to the change log.


> Index: WebKit/chromium/public/WebSecurityOrigin.h
> ===================================================================
> --- WebKit/chromium/public/WebSecurityOrigin.h	(revision 53224)
> +++ WebKit/chromium/public/WebSecurityOrigin.h	(working copy)
> @@ -55,6 +55,8 @@ public:
>          return *this;
>      }
>  
> +    WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& database);

databaseIdentifier is probably a better name


> Index: WebKit/chromium/src/WebSecurityOrigin.cpp
> ===================================================================
> --- WebKit/chromium/src/WebSecurityOrigin.cpp	(revision 53224)
> +++ WebKit/chromium/src/WebSecurityOrigin.cpp	(working copy)
> @@ -42,6 +42,11 @@ namespace WebKit {
>  class WebSecurityOriginPrivate : public SecurityOrigin {
>  };
>  
> +WebSecurityOrigin* WebSecurityOrigin::createFromDatabaseIdentifier(const WebString& database)
> +{
> +    return new WebSecurityOrigin(SecurityOrigin::createFromDatabaseIdentifier(database));

ditto, ditto

[Dimitri Glazkov (Google)]

Comment on attachment 46536 [details]
Patch

r- based on Jeremy's comments.

[Marcus Bulach]

Created attachment 46577 [details]
Patch

Thanks for the quick review!
I renamed the param and added the bug number to the ChangeLog entry.
Would you mind another look please?

Thanks,
Marcus

[Dimitri Glazkov (Google)]

Comment on attachment 46577 [details]
Patch

ok.

[WebKit Commit Bot]

Comment on attachment 46577 [details]
Patch

Clearing flags on attachment: 46577

Committed r53314: <http://trac.webkit.org/changeset/53314>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.