Bug 33648 - [Chromium] Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
Summary: [Chromium] Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 20:13 PST by Marcus Bulach
Modified: 2010-01-14 18:44 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2010-01-13 20:18 PST, Marcus Bulach 		dglazkov: review-
Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2010-01-14 09:49 PST, Marcus Bulach 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Bulach 2010-01-13 20:13:06 PST 
Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.
Comment 1 Marcus Bulach 2010-01-13 20:18:54 PST 
Created attachment 46536 [details]
Patch
Comment 2 Jeremy Orlow 2010-01-13 23:07:36 PST 
> Index: WebKit/chromium/ChangeLog
> ===================================================================
> --- WebKit/chromium/ChangeLog	(revision 53232)
> +++ WebKit/chromium/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2010-01-13  Marcus Bulach  <bulach@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier.

Need to add the bug number to the change log.


> Index: WebKit/chromium/public/WebSecurityOrigin.h
> ===================================================================
> --- WebKit/chromium/public/WebSecurityOrigin.h	(revision 53224)
> +++ WebKit/chromium/public/WebSecurityOrigin.h	(working copy)
> @@ -55,6 +55,8 @@ public:
>          return *this;
>      }
>  
> +    WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& database);

databaseIdentifier is probably a better name


> Index: WebKit/chromium/src/WebSecurityOrigin.cpp
> ===================================================================
> --- WebKit/chromium/src/WebSecurityOrigin.cpp	(revision 53224)
> +++ WebKit/chromium/src/WebSecurityOrigin.cpp	(working copy)
> @@ -42,6 +42,11 @@ namespace WebKit {
>  class WebSecurityOriginPrivate : public SecurityOrigin {
>  };
>  
> +WebSecurityOrigin* WebSecurityOrigin::createFromDatabaseIdentifier(const WebString& database)
> +{
> +    return new WebSecurityOrigin(SecurityOrigin::createFromDatabaseIdentifier(database));

ditto, ditto
Comment 3 Dimitri Glazkov (Google) 2010-01-14 07:41:57 PST 
Comment on attachment 46536 [details]
Patch

r- based on Jeremy's comments.
Comment 4 Marcus Bulach 2010-01-14 09:49:48 PST 
Created attachment 46577 [details]
Patch

Thanks for the quick review!
I renamed the param and added the bug number to the ChangeLog entry.
Would you mind another look please?

Thanks,
Marcus
Comment 5 Dimitri Glazkov (Google) 2010-01-14 14:56:04 PST 
Comment on attachment 46577 [details]
Patch

ok.
Comment 6 WebKit Commit Bot 2010-01-14 18:44:14 PST 
Comment on attachment 46577 [details]
Patch

Clearing flags on attachment: 46577

Committed r53314: <http://trac.webkit.org/changeset/53314>
Comment 7 WebKit Commit Bot 2010-01-14 18:44:19 PST 
All reviewed patches have been landed.  Closing bug.