Bug 33638 – REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

REGRESSION(53133): commit-queue no longer rejects patches with invalid committers

it simply ignores them.  It logs a message to the commit-queue logs, but doesn't actually update the bug to say it was rejected.  I expect this came of my Attachment refactoring:
http://trac.webkit.org/changeset/53133

[Eric Seidel (no email)]

This is worse than expected.  I think that this causes the commit queue to spin.  It doesn't process the patch and I think that it ends up "thinking" that it's empty and waiting another 5 minutes after the failed processing instead of correcting rejecting the patch from the queue and moving on.

So right now someone setting an commit-queue or review flag w/o having proper permissionss looks like it will HANG the queue!  I think the commit-queue was delayed for a day due to this bug!

[Eric Seidel (no email)]

I'm working on a fix now.

[Eric Seidel (no email)]

Created attachment 46618 [details]
Patch

[Eric Seidel (no email)]

I fixed the bug, and then realizing that I had to pile yet another hack into MockBugzillaTool, so I ended up fixing MockBugzillaTool too use a more dynamic system for handling mock bugs and attachments.

[Adam Barth]

Comment on attachment 46618 [details]
Patch

Nice and epic!

[Eric Seidel (no email)]

Committed r53298: <http://trac.webkit.org/changeset/53298>