Bug 33631 - webkit-patch land should not build and test by default
Summary: webkit-patch land should not build and test by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 15:52 PST by Eric Seidel (no email)
Modified: 2010-04-10 15:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2010-04-08 16:35 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2010-04-08 16:43 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2010-04-08 16:52 PDT, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2010-04-08 17:03 PDT, Ojan Vafai
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-13 15:52:44 PST
webkit-patch land should not build and test by default

Pretty much everyone passes --no-build anyway.  We should change the default to make the tool more useful.
Comment 1 Ojan Vafai 2010-04-08 16:35:50 PDT
Created attachment 52915 [details]
Patch
Comment 2 Adam Barth 2010-04-08 16:42:34 PDT
Comment on attachment 52915 [details]
Patch

As discussed in #webkit, we need to changes the queues to pass the right args and we're going to kill --no-test.
Comment 3 Ojan Vafai 2010-04-08 16:43:59 PDT
Created attachment 52916 [details]
Patch
Comment 4 Ojan Vafai 2010-04-08 16:52:11 PDT
Created attachment 52917 [details]
Patch
Comment 5 Adam Barth 2010-04-08 16:54:54 PDT
Comment on attachment 52917 [details]
Patch

I think that's correct.  We need to be careful when landing this not to create version skew in the commit-queue.
Comment 6 Ojan Vafai 2010-04-08 17:03:06 PDT
Created attachment 52918 [details]
Patch
Comment 7 Eric Seidel (no email) 2010-04-08 19:01:54 PDT
I'm happy to restart the cq whenever.  Someone should send a warning note out to webkit-dev before we land this though.
Comment 8 Eric Seidel (no email) 2010-04-08 19:03:05 PDT
Comment on attachment 52918 [details]
Patch

Why is there no case where you would want to build but not test?
Comment 9 Eric Seidel (no email) 2010-04-08 19:03:41 PDT
I guess one could always do:
build-webkit && webkit-patch land

That's actually what I used to do.  before webkit-land did it for me. :)
Comment 10 Eric Seidel (no email) 2010-04-08 19:04:15 PDT
Of course now I have the cq do all of the above for me which is about 1000 times better. :)
Comment 11 Eric Seidel (no email) 2010-04-09 00:09:51 PDT
I think that either --build-and-test or --test would be more descriptive of what it does than just --build.
Comment 12 Ojan Vafai 2010-04-09 18:33:27 PDT
Adam, you said you'll take care of landing this. Please do so before it gets too stale to apply cleanly. :)
Comment 13 Adam Barth 2010-04-09 19:24:43 PDT
Yep.  I just need Eric's attention.
Comment 14 Adam Barth 2010-04-10 15:44:52 PDT
Committed r57424: <http://trac.webkit.org/changeset/57424>