webkit-patch land should not build and test by default
Pretty much everyone passes --no-build anyway. We should change the default to make the tool more useful.
Created attachment 52915 [details]
Comment on attachment 52915 [details]
As discussed in #webkit, we need to changes the queues to pass the right args and we're going to kill --no-test.
Created attachment 52916 [details]
Created attachment 52917 [details]
Comment on attachment 52917 [details]
I think that's correct. We need to be careful when landing this not to create version skew in the commit-queue.
Created attachment 52918 [details]
I'm happy to restart the cq whenever. Someone should send a warning note out to webkit-dev before we land this though.
Comment on attachment 52918 [details]
Why is there no case where you would want to build but not test?
I guess one could always do:
build-webkit && webkit-patch land
That's actually what I used to do. before webkit-land did it for me. :)
Of course now I have the cq do all of the above for me which is about 1000 times better. :)
I think that either --build-and-test or --test would be more descriptive of what it does than just --build.
Adam, you said you'll take care of landing this. Please do so before it gets too stale to apply cleanly. :)
Yep. I just need Eric's attention.
Committed r57424: <http://trac.webkit.org/changeset/57424>