RESOLVED FIXED Bug 33631
webkit-patch land should not build and test by default 
https://bugs.webkit.org/show_bug.cgi?id=33631
Summary webkit-patch land should not build and test by default
Eric Seidel (no email)
Reported 2010-01-13 15:52:44 PST
webkit-patch land should not build and test by default Pretty much everyone passes --no-build anyway. We should change the default to make the tool more useful.
Attachments
Patch (2.45 KB, patch)
2010-04-08 16:35 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2010-04-08 16:43 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2010-04-08 16:52 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Patch (6.23 KB, patch)
2010-04-08 17:03 PDT, Ojan Vafai 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-04-08 16:35:50 PDT
Created attachment 52915 [details] Patch
Adam Barth
Comment 2 2010-04-08 16:42:34 PDT
Comment on attachment 52915 [details] Patch As discussed in #webkit, we need to changes the queues to pass the right args and we're going to kill --no-test.
Ojan Vafai
Comment 3 2010-04-08 16:43:59 PDT
Created attachment 52916 [details] Patch
Ojan Vafai
Comment 4 2010-04-08 16:52:11 PDT
Created attachment 52917 [details] Patch
Adam Barth
Comment 5 2010-04-08 16:54:54 PDT
Comment on attachment 52917 [details] Patch I think that's correct. We need to be careful when landing this not to create version skew in the commit-queue.
Ojan Vafai
Comment 6 2010-04-08 17:03:06 PDT
Created attachment 52918 [details] Patch
Eric Seidel (no email)
Comment 7 2010-04-08 19:01:54 PDT
I'm happy to restart the cq whenever. Someone should send a warning note out to webkit-dev before we land this though.
Eric Seidel (no email)
Comment 8 2010-04-08 19:03:05 PDT
Comment on attachment 52918 [details] Patch Why is there no case where you would want to build but not test?
Eric Seidel (no email)
Comment 9 2010-04-08 19:03:41 PDT
I guess one could always do: build-webkit && webkit-patch land That's actually what I used to do. before webkit-land did it for me. :)
Eric Seidel (no email)
Comment 10 2010-04-08 19:04:15 PDT
Of course now I have the cq do all of the above for me which is about 1000 times better. :)
Eric Seidel (no email)
Comment 11 2010-04-09 00:09:51 PDT
I think that either --build-and-test or --test would be more descriptive of what it does than just --build.
Ojan Vafai
Comment 12 2010-04-09 18:33:27 PDT
Adam, you said you'll take care of landing this. Please do so before it gets too stale to apply cleanly. :)
Adam Barth
Comment 13 2010-04-09 19:24:43 PDT
Yep. I just need Eric's attention.
Adam Barth
Comment 14 2010-04-10 15:44:52 PDT
Committed r57424: <http://trac.webkit.org/changeset/57424>
Note You need to log in before you can comment on or make changes to this bug.