Bug 33629 - Fix shadow drawing to do the correct computations using the base coordinate space
Summary: Fix shadow drawing to do the correct computations using the base coordinate s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-01-13 15:45 PST by Simon Fraser (smfr)
Modified: 2010-01-13 20:44 PST (History)
1 user (show)

See Also:


Attachments
Step 1: Rename patch (3.65 KB, patch)
2010-01-13 15:58 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (54.78 KB, patch)
2010-01-13 18:07 PST, Simon Fraser (smfr)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-01-13 15:45:07 PST
In Core Graphics, shadow offsets should be specified in the base coordinate system (which is the coordinate system of a newly created CGContext before any user space transforms have been applied). We need to do the right math to fix shadow drawing accordingly.
Comment 1 Simon Fraser (smfr) 2010-01-13 15:45:38 PST
<rdar://problem/7532544>
Comment 2 Simon Fraser (smfr) 2010-01-13 15:58:39 PST
Created attachment 46516 [details]
Step 1: Rename patch
Comment 3 Simon Fraser (smfr) 2010-01-13 18:07:25 PST
Created attachment 46532 [details]
Patch
Comment 4 Simon Fraser (smfr) 2010-01-13 18:08:24 PST
First patch was committed in
http://trac.webkit.org/changeset/53211
Comment 5 Simon Fraser (smfr) 2010-01-13 20:44:46 PST
http://trac.webkit.org/changeset/53235