Bug 33625 - CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
Summary: CounterNode::nextInPreOrderAfterChildren(stayWithin) does not stay within.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Carol Szabo
URL:
Keywords:
Depends on:
Blocks: 11031
  Show dependency treegraph
 
Reported: 2010-01-13 14:58 PST by Carol Szabo
Modified: 2010-01-13 19:30 PST (History)
2 users (show)

See Also:


Attachments
Proposed patch (1.58 KB, patch)
2010-01-13 16:00 PST, Carol Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carol Szabo 2010-01-13 14:58:33 PST
The same problem that bug 33600 reported about RenderObject is being inherited by virtue of copy-paste programing here.
If stayWithin has a nextSibling() the method returns it instead of null when called on stayWithin's last descendant, hence causing an iteration of the counterTree designed to stay within stayWithin's descendants, iterates to the end of the counterTree.

Patch to come soon.
Comment 1 Carol Szabo 2010-01-13 16:00:49 PST
Created attachment 46517 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-01-13 19:30:46 PST
Comment on attachment 46517 [details]
Proposed patch

Clearing flags on attachment: 46517

Committed r53230: <http://trac.webkit.org/changeset/53230>
Comment 3 WebKit Commit Bot 2010-01-13 19:30:52 PST
All reviewed patches have been landed.  Closing bug.