WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 33623
[Android] Android build is broken by addition of second file named StringBuilder.h
https://bugs.webkit.org/show_bug.cgi?id=33623
Summary
[Android] Android build is broken by addition of second file named StringBuil...
Steve Block
Reported
2010-01-13 13:54:49 PST
http://trac.webkit.org/changeset/52075
added JavaScriptCore/runtime/StringBuilder.h WebCore/platform/text/StringBuilder.h already exists. The Android build is not set up to handle multiple include files with the same name. Should multiple files with the same name be avoided? I'm not aware of any other examples of this (other than config.h). If not, the Android build system will need updating to handle this.
Attachments
Patch 1 for Bug 33623
(5.45 KB, patch)
2010-01-13 14:05 PST
,
Steve Block
levin
: review+
steveblock
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Steve Block
Comment 1
2010-01-13 14:05:07 PST
Created
attachment 46503
[details]
Patch 1 for
Bug 33623
Updates Android build system
Steve Block
Comment 2
2010-01-14 03:25:50 PST
Landed manually as
http://trac.webkit.org/changeset/53254
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug