Bug 33623 - [Android] Android build is broken by addition of second file named StringBuilder.h
Summary: [Android] Android build is broken by addition of second file named StringBuil...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Steve Block
Depends on:
Reported: 2010-01-13 13:54 PST by Steve Block
Modified: 2010-01-14 06:51 PST (History)
3 users (show)

See Also:

Patch 1 for Bug 33623 (5.45 KB, patch)
2010-01-13 14:05 PST, Steve Block
levin: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-13 13:54:49 PST
http://trac.webkit.org/changeset/52075 added JavaScriptCore/runtime/StringBuilder.h
WebCore/platform/text/StringBuilder.h already exists.
The Android build is not set up to handle multiple include files with the same name.

Should multiple files with the same name be avoided?
I'm not aware of any other examples of this (other than config.h).

If not, the Android build system will need updating to handle this.
Comment 1 Steve Block 2010-01-13 14:05:07 PST
Created attachment 46503 [details]
Patch 1 for Bug 33623

Updates Android build system
Comment 2 Steve Block 2010-01-14 03:25:50 PST
Landed manually as http://trac.webkit.org/changeset/53254