Bug 33619 - Move more of the selection and caret painting code from Frame to SelectionController
Summary: Move more of the selection and caret painting code from Frame to SelectionCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 12:37 PST by Darin Adler
Modified: 2010-01-14 12:56 PST (History)
2 users (show)

See Also:


Attachments
Patch (20.89 KB, patch)
2010-01-13 12:38 PST, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-01-13 12:37:41 PST
Move more of the selection and caret painting code from Frame to SelectionController
Comment 1 Darin Adler 2010-01-13 12:38:32 PST
Created attachment 46488 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-13 13:05:31 PST
Attachment 46488 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/184631
Comment 3 mitz 2010-01-13 13:22:15 PST
Comment on attachment 46488 [details]
Patch

> +        "layout" is usedfor other purposes in this function.

Typo: “usedfor”

> -    bool m_needsLayout : 1;       // true if the caret and expectedVisible rectangles need to be calculated
> +    bool m_needsLayout; // true if the caret and expectedVisible rectangles need to be calculated

I don’t know what expectedVisible is, in this comment that you’re moving.

r=me but this apparently breaks the Qt build: <https://webkit-commit-queue.appspot.com/results/184631>.
Comment 4 Eric Seidel (no email) 2010-01-14 12:54:36 PST
Attachment 46488 [details] was posted by a committer and has review+, assigning to Darin Adler for commit.
Comment 5 Darin Adler 2010-01-14 12:56:09 PST
http://trac.webkit.org/changeset/53218