DatabaseAuthorizer should use a CaseFoldingHash function to store the list of whitelisted sqlite functions, instead of doing m_whitelistedFunctions.contains(functionName.lower()). Also, the indenting in DatabaseAuthorizer::allowFunction() should be fixed.
Created attachment 46483 [details]
Comment on attachment 46483 [details]
Code change is fine. But normally we include the change log entry in the patch for review.
Created attachment 46486 [details]
(In reply to comment #2)
> (From update of attachment 46483 [details])
> Code change is fine. But normally we include the change log entry in the patch
> for review.
D'oh! I knew something was missing from this patch... Please take a look at the new one.
Landed as r53198.