RESOLVED FIXED 33612
Use the CaseFoldingHash function in DatabaseAuthorizer to store the list of whitelisted sqlite functions 
https://bugs.webkit.org/show_bug.cgi?id=33612
Summary Use the CaseFoldingHash function in DatabaseAuthorizer to store the list of w...
Dumitru Daniliuc
Reported 2010-01-13 12:01:54 PST
DatabaseAuthorizer should use a CaseFoldingHash function to store the list of whitelisted sqlite functions, instead of doing m_whitelistedFunctions.contains(functionName.lower()). Also, the indenting in DatabaseAuthorizer::allowFunction() should be fixed.
Attachments
patch (1.11 KB, patch)
2010-01-13 12:15 PST, Dumitru Daniliuc 		darin: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
patch (1.87 KB, patch)
2010-01-13 12:27 PST, Dumitru Daniliuc 		darin: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-01-13 12:15:21 PST
Created attachment 46483 [details] patch
Darin Adler
Comment 2 2010-01-13 12:23:06 PST
Comment on attachment 46483 [details] patch Code change is fine. But normally we include the change log entry in the patch for review.
Dumitru Daniliuc
Comment 3 2010-01-13 12:27:28 PST
Created attachment 46486 [details] patch (In reply to comment #2) > (From update of attachment 46483 [details]) > Code change is fine. But normally we include the change log entry in the patch > for review. D'oh! I knew something was missing from this patch... Please take a look at the new one.
Dumitru Daniliuc
Comment 4 2010-01-13 13:09:46 PST
Landed as r53198.
Note You need to log in before you can comment on or make changes to this bug.