Bug 33612 - Use the CaseFoldingHash function in DatabaseAuthorizer to store the list of whitelisted sqlite functions
Summary: Use the CaseFoldingHash function in DatabaseAuthorizer to store the list of w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-13 12:01 PST by Dumitru Daniliuc
Modified: 2010-01-13 13:09 PST (History)
2 users (show)

See Also:

Attachments
patch (1.11 KB, patch)
2010-01-13 12:15 PST, Dumitru Daniliuc 		darin: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
patch (1.87 KB, patch)
2010-01-13 12:27 PST, Dumitru Daniliuc 		darin: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-01-13 12:01:54 PST 
DatabaseAuthorizer should use a CaseFoldingHash function to store the list of whitelisted sqlite functions, instead of doing m_whitelistedFunctions.contains(functionName.lower()). Also, the indenting in DatabaseAuthorizer::allowFunction() should be fixed.
Comment 1 Dumitru Daniliuc 2010-01-13 12:15:21 PST 
Created attachment 46483 [details]
patch
Comment 2 Darin Adler 2010-01-13 12:23:06 PST 
Comment on attachment 46483 [details]
patch

Code change is fine. But normally we include the change log entry in the patch for review.
Comment 3 Dumitru Daniliuc 2010-01-13 12:27:28 PST 
Created attachment 46486 [details]
patch

(In reply to comment #2)
> (From update of attachment 46483 [details])
> Code change is fine. But normally we include the change log entry in the patch
> for review.

D'oh! I knew something was missing from this patch... Please take a look at the new one.
Comment 4 Dumitru Daniliuc 2010-01-13 13:09:46 PST 
Landed as r53198.