Bug 33599 - [BREWMP] Port SharedTimer with IShell_SetTimerEx.
Summary: [BREWMP] Port SharedTimer with IShell_SetTimerEx.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-01-13 08:16 PST by Kwang Yul Seo
Modified: 2010-02-01 21:02 PST (History)
1 user (show)

See Also:

Attachments
Port SharedTimer to BREW (3.71 KB, patch)
2010-01-13 08:25 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Port SharedTimer (3.67 KB, patch)
2010-01-25 01:59 PST, Kwang Yul Seo 		eric: review-
Details | Formatted Diff | Diff
Port SharedTimer (3.65 KB, patch)
2010-01-26 17:14 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-01-13 08:16:49 PST 
As fireTime passed in setSharedTimerFireTime is the absolute time, we must calcalute the interval by subtracting currentTime() from fireTime and pass the result to ISHELL_SetTimerEx.
Comment 1 Kwang Yul Seo 2010-01-13 08:25:55 PST 
Created attachment 46467 [details]
Port SharedTimer to BREW
Comment 2 Kwang Yul Seo 2010-01-25 01:59:30 PST 
Created attachment 47330 [details]
Port SharedTimer

BREW -> BREWMP in ChangeLog
Comment 3 Eric Seidel (no email) 2010-01-26 14:51:20 PST 
Comment on attachment 47330 [details]
Port SharedTimer

 30 #undef COMPILE_ASSERT

Otherwise this looks fine.
Comment 4 Kwang Yul Seo 2010-01-26 17:14:16 PST 
Created attachment 47470 [details]
Port SharedTimer

#undef COMPILE_ASSERT is removed
Comment 5 Eric Seidel (no email) 2010-02-01 15:29:56 PST 
Comment on attachment 47470 [details]
Port SharedTimer

OK.
Comment 6 WebKit Commit Bot 2010-02-01 21:02:01 PST 
Comment on attachment 47470 [details]
Port SharedTimer

Clearing flags on attachment: 47470

Committed r54200: <http://trac.webkit.org/changeset/54200>
Comment 7 WebKit Commit Bot 2010-02-01 21:02:07 PST 
All reviewed patches have been landed.  Closing bug.