WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33599
[BREWMP] Port SharedTimer with IShell_SetTimerEx.
https://bugs.webkit.org/show_bug.cgi?id=33599
Summary
[BREWMP] Port SharedTimer with IShell_SetTimerEx.
Kwang Yul Seo
Reported
2010-01-13 08:16:49 PST
As fireTime passed in setSharedTimerFireTime is the absolute time, we must calcalute the interval by subtracting currentTime() from fireTime and pass the result to ISHELL_SetTimerEx.
Attachments
Port SharedTimer to BREW
(3.71 KB, patch)
2010-01-13 08:25 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
Port SharedTimer
(3.67 KB, patch)
2010-01-25 01:59 PST
,
Kwang Yul Seo
eric
: review-
Details
Formatted Diff
Diff
Port SharedTimer
(3.65 KB, patch)
2010-01-26 17:14 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-01-13 08:25:55 PST
Created
attachment 46467
[details]
Port SharedTimer to BREW
Kwang Yul Seo
Comment 2
2010-01-25 01:59:30 PST
Created
attachment 47330
[details]
Port SharedTimer BREW -> BREWMP in ChangeLog
Eric Seidel (no email)
Comment 3
2010-01-26 14:51:20 PST
Comment on
attachment 47330
[details]
Port SharedTimer 30 #undef COMPILE_ASSERT Otherwise this looks fine.
Kwang Yul Seo
Comment 4
2010-01-26 17:14:16 PST
Created
attachment 47470
[details]
Port SharedTimer #undef COMPILE_ASSERT is removed
Eric Seidel (no email)
Comment 5
2010-02-01 15:29:56 PST
Comment on
attachment 47470
[details]
Port SharedTimer OK.
WebKit Commit Bot
Comment 6
2010-02-01 21:02:01 PST
Comment on
attachment 47470
[details]
Port SharedTimer Clearing flags on attachment: 47470 Committed
r54200
: <
http://trac.webkit.org/changeset/54200
>
WebKit Commit Bot
Comment 7
2010-02-01 21:02:07 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug