Bug 33586 - [Android] appendClassName in jni_runtime.cpp uses JSC-specific UString type
: [Android] appendClassName in jni_runtime.cpp uses JSC-specific UString type
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: Android Android
: P2 Normal
Assigned To: Steve Block
Depends on:
Blocks: 32154
  Show dependency treegraph
Reported: 2010-01-13 04:22 PST by Steve Block
Modified: 2010-01-13 10:30 PST (History)
4 users (show)

See Also:

Patch 1 for Bug 33586 (1.88 KB, patch)
2010-01-13 09:51 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-13 04:22:48 PST
appendClassName is a static helper function used in jni_runtime.cpp. This file is largely script engine independent. However, appendClassName uses the JSC-specific UString type, which causes problems on Android, where we can build with JSC or V8. 

The function should be updated to use a non-JSC-specific type.
Comment 1 Steve Block 2010-01-13 09:30:13 PST
jni_runtime was recently (http://trac.webkit.org/changeset/52329) updated to use JSC::StringBuilder, rather than UString, but the problem still stands.
Comment 2 Steve Block 2010-01-13 09:51:16 PST
Created attachment 46471 [details]
Patch 1 for Bug 33586

Uses WebCore::SringBuilder in place of JSC::StringBuilder.

Note that this also avoids the use of UString::ascii, which according to UString.h, should only be used for debugging purposes.
Comment 3 WebKit Commit Bot 2010-01-13 10:30:12 PST
Comment on attachment 46471 [details]
Patch 1 for Bug 33586

Clearing flags on attachment: 46471

Committed r53193: <http://trac.webkit.org/changeset/53193>
Comment 4 WebKit Commit Bot 2010-01-13 10:30:17 PST
All reviewed patches have been landed.  Closing bug.