Bug 33569 - [BREWMP] Add dummy main thread functions
Summary: [BREWMP] Add dummy main thread functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-01-12 19:34 PST by Kwang Yul Seo
Modified: 2010-02-02 14:34 PST (History)
1 user (show)

See Also:


Attachments
Add dummy main thread functions (2.78 KB, patch)
2010-01-12 19:38 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Add dummy main thread functions (2.77 KB, patch)
2010-01-25 01:45 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-01-12 19:34:21 PST
Add dummy initializeMainThreadPlatform and scheduleDispatchFunctionsOnMainThread.
Comment 1 Kwang Yul Seo 2010-01-12 19:38:34 PST
Created attachment 46421 [details]
Add dummy main thread functions
Comment 2 Kwang Yul Seo 2010-01-25 01:45:54 PST
Created attachment 47327 [details]
Add dummy main thread functions

BREW -> BREWMP in ChangeLog
Comment 3 Eric Seidel (no email) 2010-01-26 14:44:46 PST
Comment on attachment 47327 [details]
Add dummy main thread functions

Why does brew not need these?  Will BREW not be using mutli-threaded JS, or storage?
Comment 4 Eric Seidel (no email) 2010-01-26 14:45:08 PST
Comment on attachment 47327 [details]
Add dummy main thread functions

Removing cq+ pending further explanation of "why" this is correct.
Comment 5 Kwang Yul Seo 2010-01-27 09:43:27 PST
Currently, the BREW MP port is single-threaded and does not use features which require multi-threading. As BREW (not BREW MP) does not provide pre-emptive multi-threading, I made the port single-threaded to make it backward compatible with BREW.

With new IThread1 interface provided by BREW MP, now it is possible to implement pre-emptive multi-theading. I will add multi-threading support to BREW MP once this initial review process is finished.
Comment 6 WebKit Commit Bot 2010-02-02 14:34:22 PST
Comment on attachment 47327 [details]
Add dummy main thread functions

Clearing flags on attachment: 47327

Committed r54255: <http://trac.webkit.org/changeset/54255>
Comment 7 WebKit Commit Bot 2010-02-02 14:34:27 PST
All reviewed patches have been landed.  Closing bug.