Bug 33567 - [BREWMP] Port WTF's currentTime
Summary: [BREWMP] Port WTF's currentTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-01-12 18:12 PST by Kwang Yul Seo
Modified: 2010-02-01 17:34 PST (History)
2 users (show)

See Also:


Attachments
Port currentTime to BREW (1.93 KB, patch)
2010-01-12 18:18 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Port WTF's currentTime (1.96 KB, patch)
2010-01-22 17:44 PST, Kwang Yul Seo
eric: review-
Details | Formatted Diff | Diff
Port WTF's currentTime (1.94 KB, patch)
2010-01-26 16:35 PST, Kwang Yul Seo
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Port WTF's currentTime (1.92 KB, patch)
2010-01-26 17:02 PST, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-01-12 18:12:35 PST
Implement WTF::currentTime for BREW with GETUTCSECONDS and GETTIMEMS.
Comment 1 Kwang Yul Seo 2010-01-12 18:18:00 PST
Created attachment 46418 [details]
Port currentTime to BREW
Comment 2 Kwang Yul Seo 2010-01-22 17:44:11 PST
Created attachment 47251 [details]
Port WTF's currentTime

Use PLATFORM(BREWMP)
Comment 3 Kwang Yul Seo 2010-01-22 17:52:30 PST
"#undef COMPILE_ASSERT" is required because both WTF and BREW defines COMPILE_ASSERT. Unless we prefix WTF_ to COMPILE_ASSERT defined Assertions.h, I have to put "#undef COMPILE_ASSERT" every place where BREW headers are used. This is quite ugly.
Comment 4 Eric Seidel (no email) 2010-01-26 14:42:36 PST
Comment on attachment 47251 [details]
Port WTF's currentTime

See my comments in the other bug.  I think we should fix wtf/Assertions.h instead of each file.

Otherwise looks sane.
Comment 5 Kwang Yul Seo 2010-01-26 16:35:46 PST
Created attachment 47461 [details]
Port WTF's currentTime

Remove "#undef COMPILE_ASSERT"
Comment 6 Eric Seidel (no email) 2010-01-26 16:45:24 PST
Comment on attachment 47461 [details]
Port WTF's currentTime

Looks sane.  Looks like the patch fails to apply though, so it can't be cq+'d w/o first being updated.
Comment 7 Kwang Yul Seo 2010-01-26 17:02:10 PST
Created attachment 47464 [details]
Port WTF's currentTime

I generated a new diff with the tools.
Comment 8 Eric Seidel (no email) 2010-02-01 15:28:34 PST
Comment on attachment 47464 [details]
Port WTF's currentTime

OK.
Comment 9 WebKit Commit Bot 2010-02-01 17:33:59 PST
Comment on attachment 47464 [details]
Port WTF's currentTime

Clearing flags on attachment: 47464

Committed r54183: <http://trac.webkit.org/changeset/54183>
Comment 10 WebKit Commit Bot 2010-02-01 17:34:05 PST
All reviewed patches have been landed.  Closing bug.