RESOLVED FIXED 33567
[BREWMP] Port WTF's currentTime 
https://bugs.webkit.org/show_bug.cgi?id=33567
Summary [BREWMP] Port WTF's currentTime
Kwang Yul Seo
Reported 2010-01-12 18:12:35 PST
Implement WTF::currentTime for BREW with GETUTCSECONDS and GETTIMEMS.
Attachments
Port currentTime to BREW (1.93 KB, patch)
2010-01-12 18:18 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Port WTF's currentTime (1.96 KB, patch)
2010-01-22 17:44 PST, Kwang Yul Seo 		eric: review-
DetailsFormatted DiffDiff
Port WTF's currentTime (1.94 KB, patch)
2010-01-26 16:35 PST, Kwang Yul Seo 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
Port WTF's currentTime (1.92 KB, patch)
2010-01-26 17:02 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-12 18:18:00 PST
Created attachment 46418 [details] Port currentTime to BREW
Kwang Yul Seo
Comment 2 2010-01-22 17:44:11 PST
Created attachment 47251 [details] Port WTF's currentTime Use PLATFORM(BREWMP)
Kwang Yul Seo
Comment 3 2010-01-22 17:52:30 PST
"#undef COMPILE_ASSERT" is required because both WTF and BREW defines COMPILE_ASSERT. Unless we prefix WTF_ to COMPILE_ASSERT defined Assertions.h, I have to put "#undef COMPILE_ASSERT" every place where BREW headers are used. This is quite ugly.
Eric Seidel (no email)
Comment 4 2010-01-26 14:42:36 PST
Comment on attachment 47251 [details] Port WTF's currentTime See my comments in the other bug. I think we should fix wtf/Assertions.h instead of each file. Otherwise looks sane.
Kwang Yul Seo
Comment 5 2010-01-26 16:35:46 PST
Created attachment 47461 [details] Port WTF's currentTime Remove "#undef COMPILE_ASSERT"
Eric Seidel (no email)
Comment 6 2010-01-26 16:45:24 PST
Comment on attachment 47461 [details] Port WTF's currentTime Looks sane. Looks like the patch fails to apply though, so it can't be cq+'d w/o first being updated.
Kwang Yul Seo
Comment 7 2010-01-26 17:02:10 PST
Created attachment 47464 [details] Port WTF's currentTime I generated a new diff with the tools.
Eric Seidel (no email)
Comment 8 2010-02-01 15:28:34 PST
Comment on attachment 47464 [details] Port WTF's currentTime OK.
WebKit Commit Bot
Comment 9 2010-02-01 17:33:59 PST
Comment on attachment 47464 [details] Port WTF's currentTime Clearing flags on attachment: 47464 Committed r54183: <http://trac.webkit.org/changeset/54183>
WebKit Commit Bot
Comment 10 2010-02-01 17:34:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.