Bug 33561 – [Android] JavaClass uses JSC-specific types

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Steve Block]

JavaClass, defined in WebCore/bridge/jni/jni_class.h, uses JSC-specific types. This causes problems on Android, where we can build with JSC or V8. See
Bug 32154, which this bug blocks.

The JSC-specific version of JavaClass should be moved a different location, so that the other common code can be used for both JSC and V8.

[Steve Block]

Created attachment 46415 [details]
Patch 1 for Bug 33561

A later patch will add a version of JavaClass for V8.

[Steve Block]

Created attachment 46819 [details]
Patch 2 for Bug 33561

Corrects naming of JavaClassJSC.[cpp|h]

[WebKit Review Bot]

Attachment 46819 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
he left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:127:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:128:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:128:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:129:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:129:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:130:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:130:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:131:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:131:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:132:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:137:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.cpp:142:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/bridge/jni/jsc/JavaClassJSC.h:40:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.h:41:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.h:52:  _fields is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bridge/jni/jsc/JavaClassJSC.h:53:  _methods is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Skipping input 'WebCore/bridge/jni/jni_class.h': Can't open for reading
Skipping input 'WebCore/bridge/jni/jni_class.cpp': Can't open for reading
Total errors found: 25


If any of these errors are false positives, please file a bug against check-webkit-style.

[Steve Block]

(In reply to comment #3)
> Attachment 46819 [details] did not pass style-queue:
Will fix style in moved code in a separate patch

[Adam Barth]

Comment on attachment 46819 [details]
Patch 2 for Bug 33561

lgtm

[Steve Block]

Landed manually in http://trac.webkit.org/changeset/53443

Have opened Bug 33819 to fix style in moved code.

[Steve Block]

Style is now fixed

Closing bug as resolved.