Bug 33560 - [chromium] setReplacing call in WebFrameImpl.cpp is causing problems with multipart code
Summary: [chromium] setReplacing call in WebFrameImpl.cpp is causing problems with mul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-12 16:39 PST by Tony Chang
Modified: 2010-01-12 17:29 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.31 KB, patch)
2010-01-12 16:46 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-01-12 16:39:40 PST
In bug 31446 comment 7, Darin asks if WebFrameImpl::loadData call to setReplacing could that interact in an interesting way with this code.  Turns out he was right!  This is causing an assert to trigger with the code added in r53143 because we're trying to replace a document that already exists.

Fix coming up.
Comment 1 Tony Chang 2010-01-12 16:46:48 PST
Created attachment 46413 [details]
Patch
Comment 2 Adam Barth 2010-01-12 17:12:43 PST
Comment on attachment 46413 [details]
Patch

I think this is ok, but I'm not 100% sure.
Comment 3 WebKit Commit Bot 2010-01-12 17:29:44 PST
Comment on attachment 46413 [details]
Patch

Clearing flags on attachment: 46413

Committed r53171: <http://trac.webkit.org/changeset/53171>
Comment 4 WebKit Commit Bot 2010-01-12 17:29:49 PST
All reviewed patches have been landed.  Closing bug.