JavaString, defined in WebCore/bridge/jni/jni_runtime.h, uses JSC-specific types. This causes problems on Android, where we can build with JSC or V8. See Bug 32154, which this bug blocks. The code should re-factored to separate the JSC-specific internals from the script-independent code.
Created attachment 46412 [details] Patch 1 for Bug 33558 This moves the JSC-specific implementation of JavaString to a private implementation class. A later change will add the V8 equivalent. Also modifies JavaField::name and JavaMethod::name to return const JavaString&, rather than UString::Rep*, which is JSC-specific. Note that JavaString retains one JSC-specific method, operator UString. This is required for JSC only to allow UString::rep to be used to represent the JavaString. To avoid this anomaly, we could move the entire JavaString class to JSC and V8-specific files, but this means losing the sharing of code between the two.
Created attachment 46815 [details] Patch 2 for Bug 33558 Corrects naming of JavaStringJSC.h
Comment on attachment 46815 [details] Patch 2 for Bug 33558 Ok. I'm sad about the c-style casts, but I see that they were there in the original. Also, there are style errors in the old code, but that's probably not worth worrying about at the moment.
Landed manually as http://trac.webkit.org/changeset/53449 Will fix style errors in existing code with a later patch Closing bug as resolved