RESOLVED FIXED Bug 33547
[V8] Remove static const ints from V8CustomBinding.h 
https://bugs.webkit.org/show_bug.cgi?id=33547
Summary [V8] Remove static const ints from V8CustomBinding.h
Nate Chapin
Reported 2010-01-12 12:57:36 PST
This consists of the following: 1. Define all custom fields that need to be attached to V8 DOM objects in CodeGeneratorV8.pm. 2. Generate the indices for those fields in CodeGeneratorV8.pm. 3. Remove const ints from V8Custom 4. Remove special cases for custom field counts from V8DOMWrapper.cpp. Also, this patch will include some slight reworking of #includes, because there are a couple of files that were piggybacking on V8CustomBinding.h's includes.
Attachments
patch (60.87 KB, patch)
2010-01-12 13:10 PST, Nate Chapin 		dglazkov: review+
japhet: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2010-01-12 13:10:51 PST
Created attachment 46396 [details] patch This patch will cause a Chromium canary compile break, so cq-.
Dimitri Glazkov (Google)
Comment 2 2010-01-12 13:16:56 PST
Comment on attachment 46396 [details] patch Glorious. Can you add a FIXME to make an effort to eliminate the hard-codiness in field array composition?
Nate Chapin
Comment 3 2010-01-12 14:14:44 PST
http://trac.webkit.org/changeset/53164
Note You need to log in before you can comment on or make changes to this bug.