Bug 33546 - Add V8 bindings for PopStateEvent
Summary: Add V8 bindings for PopStateEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-12 12:35 PST by Darin Fisher (:fishd, Google)
Modified: 2010-01-12 13:28 PST (History)
0 users

See Also:


Attachments
v1 patch (7.81 KB, patch)
2010-01-12 12:35 PST, Darin Fisher (:fishd, Google)
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-01-12 12:35:01 PST
Add V8 bindings for PopStateEvent
Comment 1 Darin Fisher (:fishd, Google) 2010-01-12 12:35:50 PST
Created attachment 46390 [details]
v1 patch
Comment 2 Dimitri Glazkov (Google) 2010-01-12 12:45:53 PST
Comment on attachment 46390 [details]
v1 patch

Yay, except:

> +
> +    // NOTE: v8String converts a null String into an empty v8::String :(
> +    return v8String(state->toString());

v8StringOrNull
Comment 3 Darin Fisher (:fishd, Google) 2010-01-12 13:28:26 PST
Landed as http://trac.webkit.org/changeset/53161