Bug 33511 – QtWebKit Does Not Respect Mac Scroll Bar Preferences

• Status: RESOLVED
• Resolution: INVALID
• Component: Platform

Overview:
On Mac OS X, the Appearance section of System Preferences permits the user to select whether clicking in the scroller region causes the scroll bar to jump to the next page OR to jump to the spot that is clicked. If the Option key (aka Alt key) is pressed, the current behavior is inverted. Qt uses the style hint QStyle::SH_ScrollBar_LeftClickAbsolutePosition for this. (There is a different but similar style hint for platforms that use the middle pointer button.)


Steps to Reproduce:
Open a web page with enough vertical content to need a scroll bar. Click above or below the current scroller. The document always scrolls up or down by a page, regardless of whether the user preferences in System Preferences.


Build Date and Platform:
2010-01-09 on Mac OS X 10.6
From Qt 4.7 git repository (but the code looks in latest QtWebKit repository)


FIx: In webkit/WebCore/platform/qt/ScrollbarThemeQt.cpp, line 182, change

FROM: return QApplication::style()->styleHint(QStyle::SH_ScrollBar_MiddleClickAbsolutePosition) && evt.button() == MiddleButton;

TO: return (QApplication::style()->styleHint(QStyle::SH_ScrollBar_MiddleClickAbsolutePosition) && evt.button() == MiddleButton) ||
        (QApplication::style()->styleHint(QStyle::SH_ScrollBar_LeftClickAbsolutePosition) && evt.button() == LeftButton);

[Benjamin Poulain]

Since you already know the change, I suggest you to make the patch and attach it to this bug report.

Some information to contribute: http://trac.webkit.org/wiki/QtWebKitContrib
In short, here are the steps:
-clone the repository
-make the patch
-run "WebKitTools/Script/prepare-changelog --bug 33511" to update the changelog
-describe the change in the new entry of the changelog
-make a diff containing the patch and the changelog
-upload the diff here as an attachment
-set the review and commit-queue flags to "?"

[Kent Hansen]

Reproduced with r55986.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.