RESOLVED FIXED 33504
[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once 
https://bugs.webkit.org/show_bug.cgi?id=33504
Summary [Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once
Darin Fisher (:fishd, Google)
Reported 2010-01-11 17:08:04 PST
[Chromium] Re-work webkit_unit_tests so that WebKit is initialized only once It was wrong that I re-initialized WebKit for each test case. That may cause problems down the road since background threads may try to call through to the WebKitClient. Instead, we should change to only initialize WebKit once.
Attachments
v1 patch (10.48 KB, patch)
2010-01-11 17:09 PST, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
v2 patch (adds a comment) (10.55 KB, patch)
2010-01-11 17:10 PST, Darin Fisher (:fishd, Google) 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2010-01-11 17:09:13 PST
Created attachment 46321 [details] v1 patch
Darin Fisher (:fishd, Google)
Comment 2 2010-01-11 17:10:52 PST
Created attachment 46322 [details] v2 patch (adds a comment)
WebKit Review Bot
Comment 3 2010-01-11 17:11:27 PST
Attachment 46321 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebKit/chromium/tests/WebKitTest.h': Can't open for reading WebKit/chromium/tests/RunAllTests.cpp:32: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/RunAllTests.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/KURLTest.cpp:36: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3
WebKit Review Bot
Comment 4 2010-01-11 17:11:56 PST
Attachment 46322 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Skipping input 'WebKit/chromium/tests/WebKitTest.h': Can't open for reading WebKit/chromium/tests/RunAllTests.cpp:32: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/RunAllTests.cpp:34: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/KURLTest.cpp:36: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3
Darin Fisher (:fishd, Google)
Comment 5 2010-01-12 09:42:09 PST
I'm ignoring those style errors. The style tool gets confused about header usage in WebKit/chromium/*
Dimitri Glazkov (Google)
Comment 6 2010-01-12 09:56:29 PST
Comment on attachment 46322 [details] v2 patch (adds a comment) ok.
Darin Fisher (:fishd, Google)
Comment 7 2010-01-12 10:11:55 PST
Landed as http://trac.webkit.org/changeset/53144
Adam Barth
Comment 8 2010-01-13 01:59:49 PST
(In reply to comment #5) > I'm ignoring those style errors. The style tool gets confused about header > usage in WebKit/chromium/* Is the issue the lack of config.h? We should fix the style checker not to be confused.
Note You need to log in before you can comment on or make changes to this bug.