Bug 33499 - [Chromium] Need to clear accepted index on abandon if user accepts the selected index
Summary: [Chromium] Need to clear accepted index on abandon if user accepts the select...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-11 16:10 PST by Victor Wang
Modified: 2010-01-11 17:22 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (1.39 KB, patch)
2010-01-11 16:23 PST, Victor Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Wang 2010-01-11 16:10:24 PST 
This is for chromium only. Regression from http://trac.webkit.org/changeset/52001

If user accepts an item from dropdown list, m_acceptedIndexOnAbandon is not cleared and the dropdown will crash if it is destroyed. This is 
To repro:
1) http://code.google.com/p/chromium/issues/entry
2) Select the "template" drop-down
3) Hit B, Hit <enter>
4) Boom
Comment 1 Victor Wang 2010-01-11 16:23:57 PST 
Created attachment 46318 [details]
proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-01-11 16:32:10 PST 
Comment on attachment 46318 [details]
proposed patch

r=me.
Comment 3 Dimitri Glazkov (Google) 2010-01-11 16:47:01 PST 
Comment on attachment 46318 [details]
proposed patch

cq, take it away.
Comment 4 WebKit Commit Bot 2010-01-11 17:22:54 PST 
Comment on attachment 46318 [details]
proposed patch

Clearing flags on attachment: 46318

Committed r53113: <http://trac.webkit.org/changeset/53113>
Comment 5 WebKit Commit Bot 2010-01-11 17:22:59 PST 
All reviewed patches have been landed.  Closing bug.