Bug 33498 – REGRESSION: svg/css/circle-in-mask-with-shadow.svg failing pixel tests

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Beth Dakin]

The shadow is getting clipped away. This is probably <mask> related.

[Beth Dakin]

Created attachment 46620 [details]
Patch

[WebKit Review Bot]

Attachment 46620 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/style/SVGRenderStyle.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1

[Beth Dakin]

(In reply to comment #2)
> Attachment 46620 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/rendering/style/SVGRenderStyle.h:37:  Code inside a namespace should
> not be indented.  [whitespace/indent] [4]
> Total errors found: 1

I do not intend to fix this style problem with this patch since it would involve re-tabbing the entire header file, and it would make the actual changes to the file for the sake of fixing this bug difficult to see. However, I would be happy to re-tabulate the file in a separate patch after the fact if it makes a difference to reviewers.

[Sam Weinig]

Comment on attachment 46620 [details]
Patch

Please add the FIXME we discussed to SVGRenderStyle.h

[Beth Dakin]

Fixed with r53300.

[Eric Seidel (no email)]

Looks like this broke 6 tests on the Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r53300%20(6017)/results.html

I guess Qt probably has custom results for those tests?

[Eric Seidel (no email)]

Re-opening due to bot failures.

[Csaba Osztrogonác]

Created attachment 46643 [details]
proposed fix for Qt port

Qt port has own expected files for SVG tests, because sometimes small pixel can be occured (because of different fonts) and some other reason. eg. MACs dump SVG path with fixed point (2 decimal) number, Qt port dump it with floating point number (so many decimal as need). The latter thing is not so good, I'm going to refactor it to be same to MAC. (I prepared a patch before, but some tests should be updated with it.)

Now we should update results. The differents are analogous as in http://trac.webkit.org/changeset/53300

[Csaba Osztrogonác]

Comment on attachment 46643 [details]
proposed fix for Qt port

rs-ed by Kenneth Rohde Christiansen, anded landed in 53322.