Bug 33492 – [Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Orlow]

[Chromium] Move getSessionStorageNamespace from WebKitClient to WebViewClient

[Jeremy Orlow]

Created attachment 46308 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 46308 [details]
Patch

> Index: WebCore/ChangeLog
...
> +        No new tests. (OOPS!)

^^^ need to delete this line

> Index: WebKit/chromium/public/WebKitClient.h
...
> +    // THIS IS DEPRICATED.  WebViewClient::getSessionStorageNamespace() is the new way to access this.

^^^ deprecated


> Index: WebKit/chromium/public/WebViewClient.h

> +    // Session Storage ------------------------------------------------------
> +
> +    // Get the session storage namespace associated with this WebView.
> +    virtual WebStorageNamespace* getSessionStorageNamespace() { return 0; }

why isn't this called createSessionStorageNamespace?  if the embedder owns the returned
pointer, then you should just call this sessionStorageNamespace.

[Jeremy Orlow]

Created attachment 46315 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 46315 [details]
Patch

> Index: WebKit/chromium/public/WebViewClient.h
...
> +    // Get the session storage namespace associated with this WebView.
> +    virtual WebStorageNamespace* createSessionStorageNamespace() { return 0; }

Fix the comment to say "Create a..."

Also, please move this up into the factory section of WebViewClient.

R=me, but please fix these before committing.

[Eric Seidel (no email)]

Attachment 46315 [details] was posted by a committer and has review+, assigning to Jeremy Orlow for commit.

[Jeremy Orlow]

Committed r53180: <http://trac.webkit.org/changeset/53180>

[Jeremy Orlow]

Re-opening as my previous patch had to be reverted.

[Jeremy Orlow]

Problem fixed upstream.  Will re-land the r+'ed patch.

[Jeremy Orlow]

Committed r53210: <http://trac.webkit.org/changeset/53210>