Bug 33484 – [GTK] Add and cleanup return values of signals in view and frame

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Christian Dywan]

Created attachment 46297 [details]
Add and cleanup return values

I noticed that the return values are missing from some of the signal in WebKitWebView and one in WebKitWebFrame. This causes confusion when looking up a signal and either having crashing code or lacking documented variables.

While I was at it, I changed existing @return tags into Return value: for better readability.

[Christian Dywan]

Note the move-cursor signal. I honestly don't know what the return value is supposed to do. Is it a bug that it has no boolean accumulator?

[Gustavo Noronha (kov)]

Comment on attachment 46297 [details]
Add and cleanup return values

 1380      * * Return value: a #WebKitNavigationResponse
 1381      *

Additional * here.

I would prefer if you leave move-cursor out of this for now, and report a bug specifically about it. I don't really know whether it should have an accummulator, or if we should simply make it return void, go ahead with the rest, though. Thanks!

[Eric Seidel (no email)]

Attachment 46297 [details] was posted by a committer and has review+, assigning to Christian Dywan for commit.

[Christian Dywan]

Committed with the change to the move-cursor signal removed.

2010-02-04  Christian Dywan  <[e-mail]>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add and cleanup return values of signals in view and frame
        https://bugs.webkit.org/show_bug.cgi?id=33484

        Add missing and cleanup return values of web frame and web view signals.

        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_class_init):
        * webkit/webkitwebview.cpp:
        (DNDContentsRequest::webkit_web_view_class_init):