Bug 33461 - animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
Summary: animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33292
  Show dependency tree / graph
 
Reported: 2010-01-10 21:03 PST by Eric Seidel (no email)
Modified: 2010-01-15 09:46 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.35 KB, patch)
2010-01-14 18:07 PST, Ojan Vafai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-10 21:03:00 PST 
animations/combo-transform-translate+scale.html failed on Snow Leopard Debug Bot

I suspect this is just a flakey test.

http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r53058%20(3325)/animations/combo-transform-translate+scale-diffs.txt
--- layout-test-results/animations/combo-transform-translate+scale-expected.txt	2010-01-10 19:45:06.000000000 -0800
+++ layout-test-results/animations/combo-transform-translate+scale-actual.txt	2010-01-10 19:45:06.000000000 -0800
@@ -1,2 +1,2 @@
 This test performs an animation of the translate() and scale() operators. It animates over 2 seconds. At 0.5 and 1 second it takes a snapshot and expects the result to be within range.
-PASS
+FAIL('d' was:2.71446, expected:2.5)

http://trac.webkit.org/browser/trunk/LayoutTests/animations/combo-transform-translate+scale.html
Comment 1 Eric Seidel (no email) 2010-01-14 03:00:00 PST 
Failed again just now:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r53248%20(3417)/animations/combo-transform-translate+scale-diffs.txt

different diff than last time:
--- layout-test-results/animations/combo-transform-translate+scale-expected.txt	2010-01-14 01:40:27.000000000 -0800
+++ layout-test-results/animations/combo-transform-translate+scale-actual.txt	2010-01-14 01:40:27.000000000 -0800
@@ -1,2 +1,2 @@
 This test performs an animation of the translate() and scale() operators. It animates over 2 seconds. At 0.5 and 1 second it takes a snapshot and expects the result to be within range.
-PASS
+FAIL('f' was:111, expected:100)
Comment 2 Ojan Vafai 2010-01-14 18:07:06 PST 
Created attachment 46628 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-01-14 18:30:48 PST 
Comment on attachment 46628 [details]
Patch

Don't you want to start the timeouts from the startedTransform  callback?
Comment 4 Ojan Vafai 2010-01-14 18:37:54 PST 
(In reply to comment #3)
> (From update of attachment 46628 [details])
> Don't you want to start the timeouts from the startedTransform  callback?

It already does. The only timeout I'm removing is the one that writes out the already calculated result and calls notifyDone. The timeouts that do measurement are still started in the webkitAnimationStart handler.
Comment 5 Eric Seidel (no email) 2010-01-14 18:40:15 PST 
Comment on attachment 46628 [details]
Patch

OK.
Comment 6 Ojan Vafai 2010-01-15 09:46:15 PST 
Committed r53333: <http://trac.webkit.org/changeset/53333>