WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33455
Allows plugins to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=33455
Summary
Allows plugins to participate in accelerated compositing
Simon Fraser (smfr)
Reported
2010-01-10 17:22:08 PST
Plugins that support the Core Animation rendering model should be able to integrate into the WebCore accelerated compositing mode.
Attachments
Part 1 patch: some preparatory renaming
(6.37 KB, patch)
2010-01-10 17:24 PST
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Main patch
(17.61 KB, patch)
2010-01-11 15:04 PST
,
Simon Fraser (smfr)
kdecker
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2010-01-10 17:24:15 PST
Created
attachment 46248
[details]
Part 1 patch: some preparatory renaming
Darin Adler
Comment 2
2010-01-10 17:34:23 PST
Comment on
attachment 46248
[details]
Part 1 patch: some preparatory renaming
> - videoGraphicsLayer->setContentsToVideo((PlatformLayer *)m_qtVideoLayer.get()); > + videoGraphicsLayer->setContentsToMedia((PlatformLayer *)m_qtVideoLayer.get());
> - videoGraphicsLayer->setContentsToVideo((PlatformLayer *)m_qtVideoLayer.get()); > + videoGraphicsLayer->setContentsToMedia((PlatformLayer *)m_qtVideoLayer.get());
C++ style cast instead?
Simon Fraser (smfr)
Comment 3
2010-01-10 19:48:06 PST
Comment on
attachment 46248
[details]
Part 1 patch: some preparatory renaming
http://trac.webkit.org/changeset/53059
Simon Fraser (smfr)
Comment 4
2010-01-11 15:04:42 PST
Created
attachment 46312
[details]
Main patch
Eric Seidel (no email)
Comment 5
2010-01-11 15:43:04 PST
Maybe Adam knows why all the bubbles are red here?
Eric Seidel (no email)
Comment 6
2010-01-11 15:45:17 PST
Never mind, looks like the patch just failed to apply, which is why it's red everywhere. I think Adam was going to change that to purple at some point.
Simon Fraser (smfr)
Comment 7
2010-01-11 15:46:13 PST
I think it doesn't like that my patch is missing the base64-encoded PNG images.
Simon Fraser (smfr)
Comment 8
2010-01-11 16:16:12 PST
http://trac.webkit.org/changeset/53110
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug