Bug 33455 - Allows plugins to participate in accelerated compositing
Summary: Allows plugins to participate in accelerated compositing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-10 17:22 PST by Simon Fraser (smfr)
Modified: 2010-01-11 16:16 PST (History)
2 users (show)

See Also:


Attachments
Part 1 patch: some preparatory renaming (6.37 KB, patch)
2010-01-10 17:24 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Main patch (17.61 KB, patch)
2010-01-11 15:04 PST, Simon Fraser (smfr)
kdecker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-01-10 17:22:08 PST
Plugins that support the Core Animation rendering model should be able to integrate into the WebCore accelerated compositing mode.
Comment 1 Simon Fraser (smfr) 2010-01-10 17:24:15 PST
Created attachment 46248 [details]
Part 1 patch: some preparatory renaming
Comment 2 Darin Adler 2010-01-10 17:34:23 PST
Comment on attachment 46248 [details]
Part 1 patch: some preparatory renaming

> -            videoGraphicsLayer->setContentsToVideo((PlatformLayer *)m_qtVideoLayer.get());
> +            videoGraphicsLayer->setContentsToMedia((PlatformLayer *)m_qtVideoLayer.get());

> -            videoGraphicsLayer->setContentsToVideo((PlatformLayer *)m_qtVideoLayer.get());
> +            videoGraphicsLayer->setContentsToMedia((PlatformLayer *)m_qtVideoLayer.get());

C++ style cast instead?
Comment 3 Simon Fraser (smfr) 2010-01-10 19:48:06 PST
Comment on attachment 46248 [details]
Part 1 patch: some preparatory renaming

http://trac.webkit.org/changeset/53059
Comment 4 Simon Fraser (smfr) 2010-01-11 15:04:42 PST
Created attachment 46312 [details]
Main patch
Comment 5 Eric Seidel (no email) 2010-01-11 15:43:04 PST
Maybe Adam knows why all the bubbles are red here?
Comment 6 Eric Seidel (no email) 2010-01-11 15:45:17 PST
Never mind, looks like the patch just failed to apply, which is why it's red everywhere.  I think Adam was going to change that to purple at some point.
Comment 7 Simon Fraser (smfr) 2010-01-11 15:46:13 PST
I think it doesn't like that my patch is missing the base64-encoded PNG images.
Comment 8 Simon Fraser (smfr) 2010-01-11 16:16:12 PST
http://trac.webkit.org/changeset/53110