Bug 33427 - Web Inspector: Do not repaint line numbers while editing within line.
Summary: Web Inspector: Do not repaint line numbers while editing within line.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-09 13:04 PST by Pavel Feldman
Modified: 2010-01-10 11:07 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed change (6.25 KB, patch)
2010-01-09 13:06 PST, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-09 13:04:09 PST 
(making typing even snappier)
Comment 1 Pavel Feldman 2010-01-09 13:06:03 PST 
Created attachment 46213 [details]
[PATCH] Proposed change
Comment 2 Timothy Hatcher 2010-01-09 13:10:58 PST 
Comment on attachment 46213 [details]
[PATCH] Proposed change

> +        if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine)
> +            // Nothing to repaint.
> +            return;

This should have braces, even in the comment case, since it is multiline. See style guide, Braces clause 3.
Comment 3 Pavel Feldman 2010-01-10 11:07:39 PST 
(In reply to comment #2)
> (From update of attachment 46213 [details])
> > +        if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine)
> > +            // Nothing to repaint.
> > +            return;
> 
> This should have braces, even in the comment case, since it is multiline. See
> style guide, Braces clause 3.

Done.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/TextEditor.js
Committed r53051