Bug 33412 - Retry writes to QueueStatusServer when we get 500 errors
Summary: Retry writes to QueueStatusServer when we get 500 errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-08 17:56 PST by Adam Barth
Modified: 2010-01-10 15:14 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.59 KB, patch)
2010-01-08 17:57 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2010-01-09 16:09 PST, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-08 17:56:14 PST 
Retry writes to QueueStatusServer when we get 500 errors
Comment 1 Adam Barth 2010-01-08 17:57:23 PST 
Created attachment 46186 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-01-09 14:56:01 PST 
Comment on attachment 46186 [details]
Patch

I think this ability should be made general (i'm sure we'll need it in other places).  I also think this should eventually stop.  I don't think we should hang the queue forever if AppEngine is really wedged, or?

A general method would take some sort of closure and have some default backoff amount, and eventual "give-up" timeout, no?
Comment 3 Eric Seidel (no email) 2010-01-09 14:56:56 PST 
Comment on attachment 46186 [details]
Patch

This block of code is actually huge as is.  So breaking it down into (a) function(s), whether for use with some helper retry-thingy or not, seems useful.
Comment 4 Adam Barth 2010-01-09 16:09:54 PST 
Created attachment 46226 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-01-09 16:15:23 PST 
Comment on attachment 46226 [details]
Patch

So hot.