Bug 33394 - Optimize the number of CPUs used for building Qt and Gtk
Summary: Optimize the number of CPUs used for building Qt and Gtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-08 12:00 PST by Adam Barth
Modified: 2010-01-08 15:31 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2010-01-08 12:01 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.07 KB, patch)
2010-01-08 14:18 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-01-08 12:00:43 PST
Optimize the number of CPUs used for building Qt and Gtk
Comment 1 Adam Barth 2010-01-08 12:01:35 PST
Created attachment 46149 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-08 12:05:14 PST
style-queue ran check-webkit-style on attachment 46149 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-08 12:36:39 PST
Comment on attachment 46149 [details]
Patch

LGTM!
Comment 4 Adam Barth 2010-01-08 13:11:59 PST
Comment on attachment 46149 [details]
Patch

I'm excited that that commit-queue runs test-webkitpy for me!
Comment 5 WebKit Commit Bot 2010-01-08 14:14:30 PST
Comment on attachment 46149 [details]
Patch

Rejecting patch 46149 from commit-queue.

Failed to run "['WebKitTools/Scripts/test-webkitpy']" exit_code: 1
Last 500 characters of output:
webkitpy/webkitport_unittest.py", line 57, in test_qt_port
    self.assertEquals(QtPort.build_webkit_command(build_style="debug"), [WebKitPort.script_path("build-webkit"), "--debug", "--qt", '--makeargs="-j8"'])
AssertionError: ['WebKitTools/Scripts/build-webkit', '--debug', '--qt', '--makeargs="-j2"'] != ['WebKitTools/Scripts/build-webkit', '--debug', '--qt', '--makeargs="-j8"']

----------------------------------------------------------------------
Ran 226 tests in 0.908s

FAILED (failures=1)

Full output: http://webkit-commit-queue.appspot.com/results/171078
Comment 6 Adam Barth 2010-01-08 14:18:13 PST
Created attachment 46162 [details]
Patch
Comment 7 WebKit Commit Bot 2010-01-08 14:46:03 PST
Comment on attachment 46162 [details]
Patch

Clearing flags on attachment: 46162

Committed r53011: <http://trac.webkit.org/changeset/53011>
Comment 8 WebKit Commit Bot 2010-01-08 14:46:08 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Eric Seidel (no email) 2010-01-08 15:27:57 PST
Why did it fail on the commit-bot?
Comment 10 Adam Barth 2010-01-08 15:31:34 PST
(In reply to comment #9)
> Why did it fail on the commit-bot?

One of the expected results in test-webkitpy was set to 8, which happens to be the number of cores on my machine.