Bug 33393 – Remove unnecessary #include in FastMalloc.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yong Li]

#if FORCE_SYSTEM_MALLOC

#include <stdlib.h>
#if !OS(WINDOWS)
    #include <pthread.h>
#else
    #include "windows.h"
#endif

Not sure if <stdlib.h> is needed, but <pthread.h> or "windows.h" is definitely unnecessary.

[Yong Li]

Created attachment 46150 [details]
the patch

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 46150 [details] without any errors.

[Eric Seidel (no email)]

Comment on attachment 46150 [details]
the patch

OK.  Which platforms use FORCE_SYSTEM_MALLOC at the moment?

[Darin Adler]

Comment on attachment 46150 [details]
the patch

It's clear that the <stdlib.h> include is not needed because FastMalloc.h includes it. There is no use of pthread down here and there is an include of pthread.h above for the case where we need it. But how did you determine the windows.h include was not needed? I'll take your word for it.

[Yong Li]

(In reply to comment #4)
> (From update of attachment 46150 [details])
> It's clear that the <stdlib.h> include is not needed because FastMalloc.h
> includes it. There is no use of pthread down here and there is an include of
> pthread.h above for the case where we need it. But how did you determine the
> windows.h include was not needed? I'll take your word for it.

I cannot see any #if OS(WINOS) or something similar inside #ifdef FORCE_SYSTEM_MALLOC block. Also, I successfully made FastMalloc build for win32 with forcing FORCE_SYSTEM_MALLOC=1 :) Will commit it soon and monitor the buildbots.

[Yong Li]

landed @ r53008

bug closed