DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes but it does not have a virtual destructor. While this isn't currently causing any leaks, since there are no instances of ChildThreadDOMData or MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC compiler generates the following compilation error: "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual functions and accessible non-virtual destructor" We therefore need to add a virtual destructor to DOMData.
Do you have a patch for this, or should I write one?
Created attachment 46184 [details] Patch
(Please wait for the chromium-ews because I didn't compile this locally.)
Comment on attachment 46184 [details] Patch r=me, cq+
Comment on attachment 46184 [details] Patch Clearing flags on attachment: 46184 Committed r53037: <http://trac.webkit.org/changeset/53037>
All reviewed patches have been landed. Closing bug.
(In reply to comment #1) > Do you have a patch for this, or should I write one? Yes, I had the patch. I just got interrupted before I could upload it, then had to leave to catch my train. I woke up this morning and found the bug fixed. Thank you :) I'll try to upload my patches faster in the future.
> I'll try to upload my patches faster in the future. No worries. It just seemed like a trivial bug in code I wrote, so I fixed it.