Bug 33376 - commit-queue should run run-javascriptcore-tests
Summary: commit-queue should run run-javascriptcore-tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-01-08 04:08 PST by Eric Seidel (no email)
Modified: 2010-01-08 04:59 PST (History)
4 users (show)

See Also:

Patch (2.43 KB, patch)
2010-01-08 04:43 PST, Eric Seidel (no email)
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-08 04:08:38 PST
commit-queue should run run-javascriptcore-tests

the commit-queue landed 2 patches which broke lots of javascriptcore tests tongiht.  This could have been prevented if we just ran run-javascriptcore-tests. :(
Comment 1 Eric Seidel (no email) 2010-01-08 04:32:55 PST
I'm not sure what port flags will need to be passed otherwise this would be simple.
Comment 2 Eric Seidel (no email) 2010-01-08 04:33:19 PST
Then again, i'm not sure that it matters, since no other port besides mac will use this at first.
Comment 3 Eric Seidel (no email) 2010-01-08 04:43:13 PST
Created attachment 46132 [details]
Comment 4 WebKit Review Bot 2010-01-08 04:48:47 PST
style-queue ran check-webkit-style on attachment 46132 [details] without any errors.
Comment 5 WebKit Commit Bot 2010-01-08 04:59:14 PST
Committed r52989: <http://trac.webkit.org/changeset/52989>