Bug 33358 - commit-queue is stuck spinning due to exception
Summary: commit-queue is stuck spinning due to exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 18:02 PST by Eric Seidel (no email)
Modified: 2010-01-07 18:23 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2010-01-07 18:16 PST, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-07 18:02:31 PST 
commit-queue is stuck spinning due to exception

Landing patch
Adding ['webkit-bot-watchers@googlegroups.com'] to the CC list for bug 32641
Traceback (most recent call last):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/queueengine.py", line 104, in run
    self._delegate.process_work_item(work_item)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/commands/queues.py", line 176, in process_work_item
    self._cc_watchers(patch["bug_id"])
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/commands/queues.py", line 65, in _cc_watchers
    log("Failed to CC watchers: %s." % e)
  File "/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python2.5/HTMLParser.py", line 59, in __str__
    result = self.msg
AttributeError: 'ParseError' object has no attribute 'msg'

I should have noticed sooner.  Oops.
Comment 1 Eric Seidel (no email) 2010-01-07 18:16:30 PST 
Created attachment 46104 [details]
Patch
Comment 2 Adam Barth 2010-01-07 18:17:46 PST 
Comment on attachment 46104 [details]
Patch

yep
Comment 3 Eric Seidel (no email) 2010-01-07 18:22:38 PST 
Committed r52965: <http://trac.webkit.org/changeset/52965>
Comment 4 Eric Seidel (no email) 2010-01-07 18:23:18 PST 
Ok.  Landed and restarted the commit-queue.  Sadly it's 10 patches under at this point.  It will catch up this evening I"m sure.