Bug 33356 – style-queue should not complain about identifier names with underscores under WebKit/gtk/webkit/

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gustavo Noronha (kov)]

Our APIs use GTK+ style naming, so we need to use lower-cased, _-separated names there. An example of this happenning:

https://bugs.webkit.org/show_bug.cgi?id=32819#c4

[Adam Barth]

Created attachment 46765 [details]
Patch

[Adam Barth]

Created attachment 46771 [details]
Patch

[David Levin]

Looks fine to me, but I'd prefer Hamaji to review (and Chris to comment if he wishes), since they have been a huge amount on this (and there may be a better way that they put in place).

[Chris Jerdonek]

I would prefer to keep filename-specific logic out of cpp_style.py, and to do something like this as a configuration in checker.py.  I made a bug report about this last week here:

https://bugs.webkit.org/show_bug.cgi?id=33684

But because that enhancement isn't implemented yet, I think it's fine for now.  I'll go ahead and make a note in that report that this is another use-case for directory-specific exemptions from particular rules.  When that's implemented, this change can be refactored.

[WebKit Commit Bot]

Comment on attachment 46771 [details]
Patch

Clearing flags on attachment: 46771

Committed r53636: <http://trac.webkit.org/changeset/53636>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.