RESOLVED FIXED 33351
[Chromium] Upstream webkit unit tests from the chromium repository 
https://bugs.webkit.org/show_bug.cgi?id=33351
Summary [Chromium] Upstream webkit unit tests from the chromium repository
Darin Fisher (:fishd, Google)
Reported 2010-01-07 15:45:05 PST
[Chromium] Upstream webkit unit tests from the chromium repository The chromium repository has a number of unit tests that test WebKit and WebCore classes. My plan is to upstream these into WebKit/chromium/tests/. A webkit_unit_tests executable will be built, which we can then run on the build bots. Initial patch will just contain one test and the associated build changes to get the ball rolling.
Attachments
v1 patch (34.27 KB, patch)
2010-01-08 09:59 PST, Darin Fisher (:fishd, Google) 		dglazkov: review+
dglazkov: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2010-01-08 09:59:15 PST
Created attachment 46141 [details] v1 patch
WebKit Review Bot
Comment 2 2010-01-08 10:06:47 PST
Attachment 46141 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/tests/WebKitTest.h:36: Alphabetical sorting problem. [build/include_order] [4] WebKit/chromium/tests/KURLTest.cpp:35: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/KURLTest.cpp:37: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/chromium/tests/KURLTest.cpp:78: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:79: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:80: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:81: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:82: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:124: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:128: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:131: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:134: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:147: Use 0 instead of NULL. [readability/null] [4] WebKit/chromium/tests/KURLTest.cpp:160: ascii_kurl is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/chromium/tests/KURLTest.cpp:224: Use 0 instead of NULL. [readability/null] [5] WebKit/chromium/tests/KURLTest.cpp:398: Use 0 instead of NULL. [readability/null] [4] WebKit/chromium/tests/KURLTest.cpp:412: Use 0 instead of NULL. [readability/null] [4] WebKit/chromium/tests/KURLTest.cpp:478: Use 0 instead of NULL. [readability/null] [4] WebKit/chromium/tests/KURLTest.cpp:488: Use 0 instead of NULL. [readability/null] [4] WebKit/chromium/tests/KURLTest.cpp:593: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/tests/KURLTest.cpp:595: One space before end of line comments [whitespace/comments] [5] WebKit/chromium/tests/KURLTest.cpp:604: Missing space after , [whitespace/comma] [3] WebKit/chromium/tests/KURLTest.cpp:608: Missing space after , [whitespace/comma] [3] Total errors found: 23
Dimitri Glazkov (Google)
Comment 3 2010-01-08 11:39:54 PST
Comment on attachment 46141 [details] v1 patch LGTM after you take care of style-elves compaints.
Darin Fisher (:fishd, Google)
Comment 4 2010-01-08 12:52:18 PST
Landed as http://trac.webkit.org/changeset/53001
Note You need to log in before you can comment on or make changes to this bug.