Bug 33348 - REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
Summary: REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 15:10 PST by Maciej Stachowiak
Modified: 2010-01-07 15:34 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2010-01-07 15:11 PST, Maciej Stachowiak
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2010-01-07 15:10:14 PST
REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report )
Comment 1 Maciej Stachowiak 2010-01-07 15:11:38 PST
Created attachment 46090 [details]
Patch
Comment 2 Simon Fraser (smfr) 2010-01-07 15:15:00 PST
Comment on attachment 46090 [details]
Patch

> Index: WebKit/mac/WebView/WebView.mm
> ===================================================================
> --- WebKit/mac/WebView/WebView.mm	(revision 52952)
> +++ WebKit/mac/WebView/WebView.mm	(working copy)
> @@ -1301,6 +1301,8 @@ static bool fastDocumentTeardownEnabled(
>      settings->setApplicationChromeMode([preferences applicationChromeModeEnabled]);
>      if ([preferences userStyleSheetEnabled]) {
>          NSString* location = [[preferences userStyleSheetLocation] _web_originalDataAsString];
> +        if ([location isEqual:@"apple-dashboard://stylesheet"])

Prefer isEqualToString.

r=me
Comment 3 WebKit Review Bot 2010-01-07 15:15:17 PST
style-queue ran check-webkit-style on attachment 46090 [details] without any errors.
Comment 4 Maciej Stachowiak 2010-01-07 15:34:19 PST
Committed r52953: <http://trac.webkit.org/changeset/52953>