Bug 33347 - [v8] regression: didDestroyScriptContextForFrame no longer called
Summary: [v8] regression: didDestroyScriptContextForFrame no longer called
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Matt Perry
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 14:59 PST by Matt Perry
Modified: 2010-01-08 10:54 PST (History)
2 users (show)

See Also:

Attachments
add the call back (1.14 KB, patch)
2010-01-07 15:11 PST, Matt Perry 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Perry 2010-01-07 14:59:38 PST 
This call seems to have gotten lost in the V8Proxy refactoring. I just need to add it back to V8DOMWindowShell::disposeContextHandles.
Comment 1 Matt Perry 2010-01-07 15:11:27 PST 
Created attachment 46089 [details]
add the call back
Comment 2 WebKit Review Bot 2010-01-07 15:14:44 PST 
style-queue ran check-webkit-style on attachment 46089 [details] without any errors.
Comment 3 Adam Barth 2010-01-07 15:43:39 PST 
Comment on attachment 46089 [details]
add the call back

Looks good.  Sorry I dropped the call.  :(
Comment 4 Adam Barth 2010-01-08 10:54:51 PST 
Comment on attachment 46089 [details]
add the call back

Clearing flags on attachment: 46089

Committed r52996: <http://trac.webkit.org/changeset/52996>
Comment 5 Adam Barth 2010-01-08 10:54:57 PST 
All reviewed patches have been landed.  Closing bug.