Bug 33338 - Create a renderer for <object> and <embed>
Summary: Create a renderer for <object> and <embed>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 12:26 PST by Simon Fraser (smfr)
Modified: 2010-01-07 13:57 PST (History)
2 users (show)

See Also:


Attachments
Patch (75.58 KB, patch)
2010-01-07 12:58 PST, Simon Fraser (smfr)
kdecker: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-01-07 12:26:57 PST
RenderPartObject, which is used for iframe, object and embed, has code that is mostly plugin related. I also need to add some more plugin-specific methods, so I'd like to subclass RenderPartObject for plugins.

My proposed name is RenderEmbeddedObject.
Comment 1 Simon Fraser (smfr) 2010-01-07 12:58:08 PST
Created attachment 46076 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-07 13:03:20 PST
Attachment 46076 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/RenderEmbeddedObject.cpp:146:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:150:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:152:  One space before end of line comments  [whitespace/comments] [5]
WebCore/rendering/RenderEmbeddedObject.cpp:156:  Declaration has space between type name and * in HTMLElement *embedOrObject  [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:175:  Declaration has space between type name and * in Node *child  [whitespace/declaration] [3]
WebCore/rendering/RenderEmbeddedObject.cpp:233:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:247:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/rendering/RenderEmbeddedObject.cpp:252:  Declaration has space between type name and * in HTMLEmbedElement *o  [whitespace/declaration] [3]
Total errors found: 8