Bug 33334 - Removed an unnecessary argument from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport.html
Summary: Removed an unnecessary argument from LayoutTests/fast/dom/elementFromPoint-re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 11:32 PST by Afonso Costa
Modified: 2010-01-07 21:54 PST (History)
3 users (show)

See Also:

Attachments
Proposed patch (2.55 KB, patch)
2010-01-07 11:32 PST, Afonso Costa 		darin: review-
darin: commit-queue-
Details | Formatted Diff | Diff
Proposed patch - v2 (2.55 KB, patch)
2010-01-07 13:07 PST, Afonso Costa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Afonso Costa 2010-01-07 11:32:41 PST 
Created attachment 46070 [details]
Proposed patch

As the bug #30034 is fixed, the zoomOrNot argument is unnecessary.
Comment 1 WebKit Review Bot 2010-01-07 11:38:16 PST 
style-queue ran check-webkit-style on attachment 46070 [details] without any errors.
Comment 2 Darin Adler 2010-01-07 12:34:17 PST 
Comment on attachment 46070 [details]
Proposed patch

The zoomOrNot argument is not necessary, but we do need to test with zoomPageOut, so please don't remove that line. The rest of the patch is fine.
Comment 3 Afonso Costa 2010-01-07 13:07:09 PST 
Created attachment 46079 [details]
Proposed patch - v2

Sorry, I'm confused about the old values and the zoomPageOut operation. I've updated the proposed patch.

Thanks Darin.
Comment 4 WebKit Review Bot 2010-01-07 13:10:46 PST 
style-queue ran check-webkit-style on attachment 46079 [details] without any errors.
Comment 5 WebKit Commit Bot 2010-01-07 21:54:54 PST 
Comment on attachment 46079 [details]
Proposed patch - v2

Clearing flags on attachment: 46079

Committed r52971: <http://trac.webkit.org/changeset/52971>
Comment 6 WebKit Commit Bot 2010-01-07 21:54:59 PST 
All reviewed patches have been landed.  Closing bug.