WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
33334
Removed an unnecessary argument from LayoutTests/fast/dom/elementFromPoint-relative-to-viewport.html
https://bugs.webkit.org/show_bug.cgi?id=33334
Summary
Removed an unnecessary argument from LayoutTests/fast/dom/elementFromPoint-re...
Afonso Costa
Reported
2010-01-07 11:32:41 PST
Created
attachment 46070
[details]
Proposed patch As the
bug #30034
is fixed, the zoomOrNot argument is unnecessary.
Attachments
Proposed patch
(2.55 KB, patch)
2010-01-07 11:32 PST
,
Afonso Costa
darin
: review-
darin
: commit-queue-
Details
Formatted Diff
Diff
Proposed patch - v2
(2.55 KB, patch)
2010-01-07 13:07 PST
,
Afonso Costa
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2010-01-07 11:38:16 PST
style-queue ran check-webkit-style on
attachment 46070
[details]
without any errors.
Darin Adler
Comment 2
2010-01-07 12:34:17 PST
Comment on
attachment 46070
[details]
Proposed patch The zoomOrNot argument is not necessary, but we do need to test with zoomPageOut, so please don't remove that line. The rest of the patch is fine.
Afonso Costa
Comment 3
2010-01-07 13:07:09 PST
Created
attachment 46079
[details]
Proposed patch - v2 Sorry, I'm confused about the old values and the zoomPageOut operation. I've updated the proposed patch. Thanks Darin.
WebKit Review Bot
Comment 4
2010-01-07 13:10:46 PST
style-queue ran check-webkit-style on
attachment 46079
[details]
without any errors.
WebKit Commit Bot
Comment 5
2010-01-07 21:54:54 PST
Comment on
attachment 46079
[details]
Proposed patch - v2 Clearing flags on attachment: 46079 Committed
r52971
: <
http://trac.webkit.org/changeset/52971
>
WebKit Commit Bot
Comment 6
2010-01-07 21:54:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug