Bug 33332 – [Qt] Failed to include "QWebPage" if WebKit is seperated from Qt

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Chang Shu]

On Linux, I am trying to compile a cpp file that include "QWebPage". The webkit is from webkit.org trunk rather than the QtWebKit inside Qt4.6.0. Because the include path goes directly to WebKit/qt/Api, capitalized headers cannot be found in this directory.
The compilation would pass if webkit is from Qt itself since the Qt include directory has QtWebKit with all the capitalized headers under it.

[Chang Shu]

Created attachment 46068 [details]
fix patch

I simply added capitalized headers to Qt/Api to resolve the compilation problem. Please comment if there is a better way of doing this. thanks.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 46068 [details] without any errors.

[Simon Hausmann]

Comment on attachment 46068 [details]
fix patch

I don't think we should add these header files. In Qt they are generated automatically by a script called syncqt when packaging. That is what I plan to do as well for the webkit packaging:

During package creation these wrapping header files will be created by syncqt and installed.

[Simon Hausmann]

To me more precise: The packaging that I have in mind involves building WebKit and then installing the header files into their proper location ($QTDIR/include/QtWebKit), so that application developers can continue to use QT += webkit in their .pro files, even if they installed a newer webkit package.

[Chang Shu]

(In reply to comment #4)
> To me more precise: The packaging that I have in mind involves building WebKit
> and then installing the header files into their proper location
> ($QTDIR/include/QtWebKit), so that application developers can continue to use
> QT += webkit in their .pro files, even if they installed a newer webkit
> package.

Simon, thanks for the review! I noticed the header files were generated in Qt but I thought I could use a shortcut. Yeah, I agree we should generate these files instead of checking them in. So, are you going to take care of this or you expect me to do something?

[Simon Hausmann]

(In reply to comment #5)
> (In reply to comment #4)
> > To me more precise: The packaging that I have in mind involves building WebKit
> > and then installing the header files into their proper location
> > ($QTDIR/include/QtWebKit), so that application developers can continue to use
> > QT += webkit in their .pro files, even if they installed a newer webkit
> > package.
> 
> Simon, thanks for the review! I noticed the header files were generated in Qt
> but I thought I could use a shortcut. Yeah, I agree we should generate these
> files instead of checking them in. So, are you going to take care of this or
> you expect me to do something?

I'll take care of it :)

I'm currently in the process of documenting the packagine steps and procedures at http://trac.webkit.org/wiki/QtWebKitPackaging