Bug 33331 - WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins
Summary: WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P1 Normal
Assignee: Kevin Decker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 11:15 PST by Kevin Decker
Modified: 2010-01-07 12:27 PST (History)
0 users

See Also:

Attachments
proposed fix. (4.48 KB, patch)
2010-01-07 11:18 PST, Kevin Decker 		simon.fraser: review-
Details | Formatted Diff | Diff
Updated patch per Simon's feedback (4.66 KB, patch)
2010-01-07 12:23 PST, Kevin Decker 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Decker 2010-01-07 11:15:43 PST 
WebHostedNetscapePluginView should pass acceleratedCompositingEnabled bool to NetscapePluginHostManager when instantiating plug-ins
Comment 1 Kevin Decker 2010-01-07 11:18:30 PST 
Created attachment 46067 [details]
proposed fix.
Comment 2 Simon Fraser (smfr) 2010-01-07 11:31:52 PST 
Comment on attachment 46067 [details]
proposed fix.

>      _proxy = NetscapePluginHostManager::shared().instantiatePlugin(_pluginPackage.get(), self, _MIMEType.get(), _attributeKeys.get(), _attributeValues.get(), userAgent, _sourceURL.get(), 
> -                                                                   _mode == NP_FULL, _isPrivateBrowsingEnabled);
> +                                                                   _mode == NP_FULL, _isPrivateBrowsingEnabled, [[[self webView] preferences] acceleratedCompositingEnabled]);

This also needs to check USE(ACCELERATED_COMPOSITING).
Comment 3 Kevin Decker 2010-01-07 12:23:17 PST 
Created attachment 46071 [details]
Updated patch per Simon's feedback
Comment 4 Kevin Decker 2010-01-07 12:27:04 PST 
Committed revision 52942.