Bug 33312 - [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
Summary: [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-01-07 01:38 PST by Zoltan Horvath
Modified: 2010-01-07 04:14 PST (History)
2 users (show)

See Also:


Attachments
proposed patch (1.23 KB, patch)
2010-01-07 01:40 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
updated proposed patch (1.26 KB, patch)
2010-01-07 01:53 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch (1.19 KB, patch)
2010-01-07 02:02 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch for mac (1.32 KB, patch)
2010-01-07 03:49 PST, Zoltan Horvath
no flags Details | Formatted Diff | Diff
updated proposed patch for mac (1.29 KB, patch)
2010-01-07 04:01 PST, Zoltan Horvath
zecke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2010-01-07 01:38:10 PST
Change pByte to static_cast<AllocAlignmentInteger*>(old_ptr), because pByte (it was in an older patch and has not been updated) doesn't exist.
Comment 1 Zoltan Horvath 2010-01-07 01:40:21 PST
Created attachment 46032 [details]
proposed patch
Comment 2 WebKit Review Bot 2010-01-07 01:44:42 PST
Attachment 46032 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:3798:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1
Comment 3 Holger Freyther 2010-01-07 01:51:06 PST
The patch looks fine...  some comments would be:
   - Refer to the commit that broke/added it.
   - You could use the same thing as with new_ptr (as in the original patch)
   - Or try +=..

   - Or just treat it as the buildfix and commit.
Comment 4 Zoltan Horvath 2010-01-07 01:53:21 PST
Created attachment 46034 [details]
updated proposed patch
Comment 5 WebKit Review Bot 2010-01-07 01:55:26 PST
Attachment 46034 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/FastMalloc.cpp:3798:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1
Comment 6 Zoltan Horvath 2010-01-07 02:02:00 PST
Created attachment 46035 [details]
proposed patch
Comment 7 WebKit Review Bot 2010-01-07 02:05:52 PST
style-queue ran check-webkit-style on attachment 46035 [details] without any errors.
Comment 8 Holger Freyther 2010-01-07 02:16:35 PST
Comment on attachment 46035 [details]
proposed patch

Okay. the += sizeof() should be equivalent to casting the address to the AllocAlignmentInteger* and then adding one (as done for new_ptr)...
Comment 9 Zoltan Horvath 2010-01-07 02:19:54 PST
Comment on attachment 46035 [details]
proposed patch

Clearing flags on attachment: 46035

Committed r52911: <http://trac.webkit.org/changeset/52911>
Comment 10 Zoltan Horvath 2010-01-07 02:20:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Zoltan Horvath 2010-01-07 03:49:45 PST
Created attachment 46042 [details]
proposed patch for mac
Comment 12 Zoltan Horvath 2010-01-07 03:50:21 PST
Reopened because of Mac patch.
Comment 13 WebKit Review Bot 2010-01-07 03:54:34 PST
style-queue ran check-webkit-style on attachment 46042 [details] without any errors.
Comment 14 Holger Freyther 2010-01-07 03:55:44 PST
I think the patch is wrong. It should be '+1' instead of the sizeof.
Comment 15 Zoltan Horvath 2010-01-07 04:01:48 PST
Created attachment 46044 [details]
updated proposed patch for mac
Comment 16 Holger Freyther 2010-01-07 04:03:35 PST
Comment on attachment 46044 [details]
updated proposed patch for mac

Okay.
Comment 17 Zoltan Horvath 2010-01-07 04:14:11 PST
Committed r52918: <http://trac.webkit.org/changeset/52918>