Bug 33311 - Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
Summary: Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Blocker
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 01:23 PST by Gabor Loki
Modified: 2010-01-07 23:43 PST (History)
3 users (show)

See Also:


Attachments
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled (3.31 KB, patch)
2010-01-07 01:23 PST, Gabor Loki
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2010-01-07 01:23:10 PST
Created attachment 46030 [details]
Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled

When all optimizations are disabled for JSValue32 we have the following error:
In function `JSC::JIT::emit_op_get_by_pname(JSC::Instruction*)':
undefined reference to `JSC::JIT::compileGetDirectOffset(RegisterID, RegisterID, RegisterID, RegisterID, RegisterID)'

The fix moves compileGetDirectOffset function to the common part of Value32.
Comment 1 WebKit Review Bot 2010-01-07 01:23:43 PST
style-queue ran check-webkit-style on attachment 46030 [details] without any errors.
Comment 2 Gabor Loki 2010-01-07 23:43:00 PST
Committed revision 52975.