Bug 33284 - SVGTextElement & friends need to implement svgAttributeChanged
Summary: SVGTextElement & friends need to implement svgAttributeChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 17:54 PST by Nikolas Zimmermann
Modified: 2010-01-07 16:37 PST (History)
3 users (show)

See Also:

Attachments
Initial patch (21.55 KB, patch)
2010-01-06 19:26 PST, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Updated patch (21.72 KB, patch)
2010-01-07 07:24 PST, Nikolas Zimmermann 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-01-06 17:54:03 PST 
SVGTextElement & friends need to implement svgAttributeChanged. Dynamic updates of certain properties will fail at the moment. More info to come.
Comment 1 Nikolas Zimmermann 2010-01-06 19:26:47 PST 
Created attachment 46015 [details]
Initial patch
Comment 2 WebKit Review Bot 2010-01-06 19:31:30 PST 
style-queue ran check-webkit-style on attachment 46015 [details] without any errors.
Comment 3 Eric Seidel (no email) 2010-01-06 23:10:37 PST 
Comment on attachment 46015 [details]
Initial patch

An Enum instead of a Bool is always clearer:
 42         static bool parseTransformAttribute(SVGTransformList*, const UChar*& ptr, const UChar* end, bool emptyList = true);
Comment 4 Nikolas Zimmermann 2010-01-07 07:24:16 PST 
Created attachment 46051 [details]
Updated patch

Eric is right, fixed.
Comment 5 WebKit Review Bot 2010-01-07 07:26:37 PST 
style-queue ran check-webkit-style on attachment 46051 [details] without any errors.
Comment 6 Dirk Schulze 2010-01-07 09:11:43 PST 
Comment on attachment 46051 [details]
Updated patch

LGTM. r=me
Comment 7 Eric Seidel (no email) 2010-01-07 11:42:55 PST 
It was not clear to me that the test coverage was complete, which is why I was slow to review... well, that and I was incredibly tired when I looked at the bug. :)  Thank you both.
Comment 8 Nikolas Zimmermann 2010-01-07 16:37:06 PST 
Landed in r52960.